fix: apply --no-color flag to huh interactive prompts (#454)

Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>

Author: srtaalej

internal/iostreams/forms.go

@@ -32,7 +32,9 @@ import (
 // newForm wraps a field in an interactive form with optional Slack theming.
 func newForm(io *IOStreams, field huh.Field) *huh.Form {
 	form := huh.NewForm(huh.NewGroup(field))
-	if io != nil && io.config.WithExperimentOn(experiment.Lipgloss) {
+	if io != nil && io.config.NoColor {
+		form = form.WithTheme(style.ThemePlain())
+	} else if io != nil && io.config.WithExperimentOn(experiment.Lipgloss) {
 		form = form.WithTheme(style.ThemeSlack())
 	} else {
 		form = form.WithTheme(style.ThemeSurvey())

internal/iostreams/forms_test.go

@@ -415,6 +415,47 @@ func TestFormsUseSlackTheme(t *testing.T) {
 	})
 }
 
+func TestFormsNoColor(t *testing.T) {
+	t.Run("forms use plain theme with no-color", func(t *testing.T) {
+		fsMock := slackdeps.NewFsMock()
+		osMock := slackdeps.NewOsMock()
+		osMock.AddDefaultMocks()
+		cfg := config.NewConfig(fsMock, osMock)
+		cfg.NoColor = true
+		io := NewIOStreams(cfg, fsMock, osMock)
+
+		var selected string
+		f := buildSelectForm(io, "Pick", []string{"A", "B"}, SelectPromptConfig{}, &selected)
+		f.Update(f.Init())
+
+		view := f.View()
+		// Title and option lines should have no ANSI codes
+		for _, line := range strings.Split(view, "\n")[:3] {
+			assert.Equal(t, ansi.Strip(line), line, "content line should have no ANSI codes")
+		}
+	})
+
+	t.Run("no-color takes priority over lipgloss experiment", func(t *testing.T) {
+		fsMock := slackdeps.NewFsMock()
+		osMock := slackdeps.NewOsMock()
+		osMock.AddDefaultMocks()
+		cfg := config.NewConfig(fsMock, osMock)
+		cfg.NoColor = true
+		cfg.ExperimentsFlag = []string{"lipgloss"}
+		cfg.LoadExperiments(context.Background(), func(_ context.Context, _ string, _ ...any) {})
+		io := NewIOStreams(cfg, fsMock, osMock)
+
+		var selected string
+		f := buildSelectForm(io, "Pick", []string{"A", "B"}, SelectPromptConfig{}, &selected)
+		f.Update(f.Init())
+
+		view := f.View()
+		for _, line := range strings.Split(view, "\n")[:3] {
+			assert.Equal(t, ansi.Strip(line), line, "content line should have no ANSI codes even with lipgloss experiment on")
+		}
+	})
+}
+
 func TestFormsUseSurveyTheme(t *testing.T) {
 	t.Run("multi-select uses survey prefix without lipgloss", func(t *testing.T) {
 		var selected []string

internal/style/theme.go

@@ -122,6 +122,42 @@ func Chevron() string {
 	return "❱"
 }
 
+// ThemePlain returns a huh Theme with no colors or formatting.
+func ThemePlain() huh.Theme {
+	return huh.ThemeFunc(func(_ bool) *huh.Styles {
+		t := huh.ThemeBase(false)
+		t.Focused.Title = lipgloss.NewStyle()
+		t.Focused.Description = lipgloss.NewStyle()
+		t.Focused.ErrorIndicator = lipgloss.NewStyle().SetString(" *")
+		t.Focused.ErrorMessage = lipgloss.NewStyle()
+		t.Focused.SelectSelector = lipgloss.NewStyle().SetString("> ")
+		t.Focused.Option = lipgloss.NewStyle()
+		t.Focused.MultiSelectSelector = lipgloss.NewStyle().SetString("> ")
+		t.Focused.SelectedOption = lipgloss.NewStyle()
+		t.Focused.SelectedPrefix = lipgloss.NewStyle().SetString("[x] ")
+		t.Focused.UnselectedOption = lipgloss.NewStyle()
+		t.Focused.UnselectedPrefix = lipgloss.NewStyle().SetString("[ ] ")
+		t.Focused.FocusedButton = lipgloss.NewStyle().SetString("  >").PaddingRight(3)
+		t.Focused.BlurredButton = lipgloss.NewStyle().SetString("   ").PaddingRight(3)
+		t.Focused.TextInput.Cursor = lipgloss.NewStyle()
+		t.Focused.TextInput.Prompt = lipgloss.NewStyle()
+		t.Focused.TextInput.Placeholder = lipgloss.NewStyle()
+		t.Focused.TextInput.Text = lipgloss.NewStyle()
+		t.Focused.Base = lipgloss.NewStyle().PaddingLeft(1).BorderStyle(lipgloss.ThickBorder()).BorderLeft(true)
+		t.Blurred = t.Focused
+		t.Blurred.Base = t.Focused.Base.BorderStyle(lipgloss.HiddenBorder())
+		t.Blurred.SelectSelector = lipgloss.NewStyle().SetString("  ")
+		t.Blurred.MultiSelectSelector = lipgloss.NewStyle().SetString("  ")
+		t.Help.ShortKey = lipgloss.NewStyle()
+		t.Help.ShortDesc = lipgloss.NewStyle()
+		t.Help.ShortSeparator = lipgloss.NewStyle()
+		t.Help.FullKey = lipgloss.NewStyle()
+		t.Help.FullDesc = lipgloss.NewStyle()
+		t.Help.FullSeparator = lipgloss.NewStyle()
+		return t
+	})
+}
+
 // ThemeSurvey returns a huh Theme that matches the legacy survey prompt styling.
 // Applied when experiment.Lipgloss is off.
 func ThemeSurvey() huh.Theme {

internal/style/theme_test.go

@@ -115,6 +115,40 @@ func TestThemeSurvey(t *testing.T) {
 	}
 }
 
+func TestThemePlain(t *testing.T) {
+	theme := ThemePlain().Theme(false)
+	tests := map[string]struct {
+		rendered string
+		expected string
+	}{
+		"title renders plain text": {
+			rendered: theme.Focused.Title.Render("x"),
+			expected: "x",
+		},
+		"error message renders plain text": {
+			rendered: theme.Focused.ErrorMessage.Render("err"),
+			expected: "err",
+		},
+		"select selector renders plain >": {
+			rendered: theme.Focused.SelectSelector.Render(),
+			expected: "> ",
+		},
+		"selected prefix renders [x]": {
+			rendered: theme.Focused.SelectedPrefix.Render(),
+			expected: "[x] ",
+		},
+		"unselected prefix renders [ ]": {
+			rendered: theme.Focused.UnselectedPrefix.Render(),
+			expected: "[ ] ",
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			assert.Equal(t, tc.expected, tc.rendered)
+		})
+	}
+}
+
 func TestChevron(t *testing.T) {
 	tests := map[string]struct {
 		styleEnabled bool