fixes related to reviewer suggestions

Author: srtaalej

internal/iostreams/printer.go

@@ -89,7 +89,11 @@ func (io *IOStreams) PrintInfo(ctx context.Context, shouldTrace bool, format str
 		span, _ := opentracing.StartSpanFromContext(ctx, "printInfo", opentracing.Tag{Key: "printInfo", Value: message})
 		defer span.Finish()
 	}
-	io.Stdout.Println(message)
+	if style.IsCharmEnabled() {
+		io.Stdout.Println(message)
+	} else {
+		io.Stdout.Println(style.Styler().Reset(message))
+	}
 }
 
 // PrintTrace prints traceID and values to stdout if SLACK_TEST_TRACE=true

internal/pkg/apps/install_test.go

@@ -1686,26 +1686,30 @@ func TestContinueDespiteWarning(t *testing.T) {
 	tests := map[string]struct {
 		warnings       slackerror.Warnings
 		confirmPrompt  bool
+		expectsPrompt  bool
 		expectedResult bool
 	}{
 		"user confirms breaking change": {
 			warnings: slackerror.Warnings{
 				{Code: "breaking_change", Message: "something changed"},
 			},
 			confirmPrompt:  true,
+			expectsPrompt:  true,
 			expectedResult: true,
 		},
 		"user declines breaking change": {
 			warnings: slackerror.Warnings{
 				{Code: "breaking_change", Message: "something changed"},
 			},
 			confirmPrompt:  false,
+			expectsPrompt:  true,
 			expectedResult: false,
 		},
 		"non-breaking warning continues without prompt": {
 			warnings: slackerror.Warnings{
 				{Code: "some_warning", Message: "just a warning"},
 			},
+			expectsPrompt:  false,
 			expectedResult: true,
 		},
 	}
@@ -1729,6 +1733,9 @@ func TestContinueDespiteWarning(t *testing.T) {
 			result, err := continueDespiteWarning(ctx, clients, tc.warnings)
 			require.NoError(t, err)
 			assert.Equal(t, tc.expectedResult, result)
+			if !tc.expectsPrompt {
+				clientsMock.IO.AssertNotCalled(t, "ConfirmPrompt", mock.Anything, "Confirm changes?", false)
+			}
 		})
 	}
 }

internal/style/style_test.go

@@ -129,18 +129,30 @@ func TestEmojiEmpty(t *testing.T) {
 }
 
 func TestToggleCharm(t *testing.T) {
-	defer func() {
-		isCharmEnabled = false
-	}()
-	t.Run("enables charm styling", func(t *testing.T) {
-		ToggleCharm(true)
-		assert.True(t, isCharmEnabled)
-	})
-	t.Run("disables charm styling", func(t *testing.T) {
-		isCharmEnabled = true
-		ToggleCharm(false)
-		assert.False(t, isCharmEnabled)
-	})
+	tests := map[string]struct {
+		initial  bool
+		toggle   bool
+		expected bool
+	}{
+		"enables charm styling": {
+			initial:  false,
+			toggle:   true,
+			expected: true,
+		},
+		"disables charm styling": {
+			initial:  true,
+			toggle:   false,
+			expected: false,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			isCharmEnabled = tc.initial
+			defer func() { isCharmEnabled = false }()
+			ToggleCharm(tc.toggle)
+			assert.Equal(t, tc.expected, isCharmEnabled)
+		})
+	}
 }
 
 // testStyleFunc verifies a style function returns the original text (stripped of ANSI)