Apply suggestions from code review

Co-authored-by: Eden Zimbelman <zim@o526.net>

Author: srtaalej

internal/api/icon.go

@@ -36,7 +36,7 @@ import (
 const (
 	appIconMethod = "apps.hosted.icon"
 	// AppIconSetMethod is the API method for setting app icons for non-hosted apps.
-	AppIconSetMethod = "apps.icon.set"
+	appIconSetMethod = "apps.icon.set"
 )
 
 // IconResult details to be saved
@@ -48,7 +48,8 @@ type iconResponse struct {
 	IconResult
 }
 
-// Icon updates a Slack App's icon
+// Icon updates a hosted Slack app icon
+// DEPRECATED: Prefer "IconSet" instead
 func (c *Client) Icon(ctx context.Context, fs afero.Fs, token, appID, iconFilePath string) (IconResult, error) {
 	return c.uploadIcon(ctx, fs, token, appID, iconFilePath, appIconMethod, "file")
 }

internal/pkg/apps/install.go

@@ -660,7 +660,7 @@ func updateIcon(ctx context.Context, clients *shared.ClientFactory, iconPath, ap
 
 	// var iconResp apiclient.IconResult
 	var err error
-	_, err = clients.API().Icon(ctx, clients.Fs, token, appID, iconPath)
+	_, err = clients.API().SetIcon(ctx, clients.Fs, token, appID, iconPath)
 	if err != nil {
 		// TODO: separate the icon upload into a different function because if an error is returned
 		// the new app_id might be ignored and next time we'll create another app.