test: assert cmd.ExecuteContext flushes exit code to logstash (#64)

* test: assert cmd.ExecuteContext flushes exit code to logstash

* refactor: remove mock implementation of logstash flushes from iostreams

* test: remove default mock for FlushToLogstash

---------

Co-authored-by: @zimeg <zim@o526.net>

Author: mwbrooks

cmd/root_test.go

@@ -27,6 +27,7 @@ import (
 	"github.com/slackapi/slack-cli/test/testutil"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 )
 
@@ -103,6 +104,7 @@ func TestExecuteContext(t *testing.T) {
 			// Mock clients
 			clientsMock := shared.NewClientsMock()
 			clientsMock.AddDefaultMocks()
+			clientsMock.EventTracker.On("FlushToLogstash", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
 			clients := shared.NewClientFactory(clientsMock.MockClientFactory())
 
 			// Mock command
@@ -118,8 +120,8 @@ func TestExecuteContext(t *testing.T) {
 			output := clientsMock.GetCombinedOutput()
 
 			// Assertions
-			// TODO: Assert that the event tracker was called with the correct exit code
 			require.Equal(t, tt.expectedExitCode, clients.IO.GetExitCode())
+			clientsMock.EventTracker.AssertCalled(t, "FlushToLogstash", mock.Anything, mock.Anything, mock.Anything, tt.expectedExitCode)
 
 			for _, expectedOutput := range tt.expectedOutputs {
 				require.Contains(t, output, expectedOutput)

internal/iostreams/iostreams_mock.go

@@ -118,5 +118,3 @@ func (m *IOStreamsMock) InitLogFile(ctx context.Context) error {
 func (m *IOStreamsMock) FinishLogFile(ctx context.Context) {}
 
 func (m *IOStreamsMock) FlushToLogFile(ctx context.Context, prefix, errStr string) error { return nil }
-
-func (m *IOStreamsMock) FlushToLogstash(ctx context.Context) error { return nil }

internal/shared/clients_mock.go

@@ -75,6 +75,7 @@ func (m *ClientsMock) AddDefaultMocks() {
 	m.AuthInterface.AddDefaultMocks()
 	m.Browser.AddDefaultMocks()
 	m.Cobra.AddDefaultMocks()
+	m.EventTracker.AddDefaultMocks()
 	m.IO.AddDefaultMocks()
 	m.Os.AddDefaultMocks()
 }
@@ -86,6 +87,7 @@ func (m *ClientsMock) MockClientFactory() func(c *ClientFactory) {
 		clients.Browser = func() slackdeps.Browser { return m.Browser }
 		clients.Cobra.GenMarkdownTree = m.Cobra.GenMarkdownTree
 		clients.Config = m.Config
+		clients.EventTracker = m.EventTracker
 		clients.Os = m.Os
 		clients.IO = m.IO
 		clients.Fs = m.Fs

internal/tracking/tracking_mock.go

@@ -27,14 +27,32 @@ type EventTrackerMock struct {
 }
 
 func (m *EventTrackerMock) AddDefaultMocks() {
-	m.On("FlushToLogstash", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(nil)
+	m.On("SetAppEnterpriseID", mock.Anything)
+	m.On("SetAppTeamID", mock.Anything)
+	m.On("SetAppTemplate", mock.Anything)
+	m.On("SetAppUserID", mock.Anything)
+	m.On("SetAuthEnterpriseID", mock.Anything)
+	m.On("SetAuthTeamID", mock.Anything)
+	m.On("SetAuthUserID", mock.Anything)
+	m.On("SetErrorCode", mock.Anything)
+	m.On("SetErrorMessage", mock.Anything)
 }
 
-func (m *EventTrackerMock) FlushToLogstash(ctx context.Context, cfg config.Config, io iostreams.IOStreamer, exitCode iostreams.ExitCode) error {
-	args := m.Called(ctx)
+func (m *EventTrackerMock) FlushToLogstash(ctx context.Context, cfg *config.Config, io iostreams.IOStreamer, exitCode iostreams.ExitCode) error {
+	args := m.Called(ctx, cfg, io, exitCode)
 	return args.Error(0)
 }
 
+func (m *EventTrackerMock) getSessionData() EventData {
+	args := m.Called()
+	return args.Get(0).(EventData)
+}
+
+func (m *EventTrackerMock) cleanSessionData(data EventData) EventData {
+	args := m.Called(data)
+	return args.Get(0).(EventData)
+}
+
 func (m *EventTrackerMock) SetErrorCode(code string) {
 	m.Called(code)
 }