Skip to content

Commit 5d08f1c

Browse files
authored
test: fix failing version tests if compilation flags are not provided (#67)
test: fix version tests failing in VSCode/Cursor
1 parent 8e2e918 commit 5d08f1c

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

cmd/root_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ func TestExecuteContext(t *testing.T) {
130130
}
131131
}
132132

133-
// FYI: do not try to run this test in vscode using the run/debug test inline test helper; as the assertions in this test will fail in that context
134133
func TestVersionFlags(t *testing.T) {
135134
ctx := slackcontext.MockContext(t.Context())
136135

internal/pkg/version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
const EnvTestVersion = "SLACK_TEST_VERSION"
2525

2626
// Version is set with `git describe` at build time in the Makefile
27-
var Version = "dev"
27+
var Version = "v0.0.0-dev"
2828

2929
// init attempts to update Version from an env var for testing purposes
3030
func init() {

0 commit comments

Comments
 (0)