Skip to content

Commit 6014806

Browse files
committed
test: drop redundant agent_view round-trip test
The agent_view JSON marshal cases live in Test_AppManifest_AppFeatures alongside other features. The standalone round-trip test had no precedent for sibling properties like assistant_view.
1 parent f8de543 commit 6014806

1 file changed

Lines changed: 0 additions & 48 deletions

File tree

internal/shared/types/app_manifest_test.go

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -260,54 +260,6 @@ func Test_AppManifest_AppFeatures(t *testing.T) {
260260
}
261261
}
262262

263-
func Test_AppManifest_AgentView_RoundTrip(t *testing.T) {
264-
original := AppManifest{
265-
DisplayInformation: DisplayInformation{Name: "agent_smith"},
266-
Features: &AppFeatures{
267-
AgentView: &AgentView{
268-
AgentDescription: "summarizes threads",
269-
SuggestedPrompts: []SuggestedPrompts{
270-
{Title: "summarize", Message: "please summarize"},
271-
},
272-
Actions: []AgentViewAction{
273-
{Name: "open_settings", Description: "Open the agent settings panel."},
274-
},
275-
},
276-
},
277-
}
278-
279-
t.Run("JSON round-trip preserves agent_view", func(t *testing.T) {
280-
blob, err := json.Marshal(original)
281-
require.NoError(t, err)
282-
assert.Contains(t, string(blob), `"agent_view":{`)
283-
284-
var got AppManifest
285-
require.NoError(t, json.Unmarshal(blob, &got))
286-
assert.Equal(t, original.Features.AgentView, got.Features.AgentView)
287-
})
288-
289-
t.Run("YAML round-trip preserves agent_view", func(t *testing.T) {
290-
blob, err := yaml.Marshal(original)
291-
require.NoError(t, err)
292-
assert.Contains(t, string(blob), "agent_view:")
293-
assert.Contains(t, string(blob), "agent_description: summarizes threads")
294-
295-
var got AppManifest
296-
require.NoError(t, yaml.Unmarshal(blob, &got))
297-
assert.Equal(t, original.Features.AgentView, got.Features.AgentView)
298-
})
299-
300-
t.Run("nil agent_view is omitted from JSON", func(t *testing.T) {
301-
manifest := AppManifest{
302-
DisplayInformation: DisplayInformation{Name: "no_agent"},
303-
Features: &AppFeatures{BotUser: BotUser{DisplayName: "no_agent"}},
304-
}
305-
blob, err := json.Marshal(manifest)
306-
require.NoError(t, err)
307-
assert.NotContains(t, string(blob), "agent_view")
308-
})
309-
}
310-
311263
func Test_AppManifest_AppSettings_SiwsLinks(t *testing.T) {
312264
expectedSiws := SiwsLinks{
313265
InitiateURI: "an initiate uri",

0 commit comments

Comments
 (0)