Merge latest main while preserving docs search functionality

Made-with: Cursor

Author: lukegalbraithrussell

.claude/.gitignore

@@ -0,0 +1,4 @@
+CLAUDE.local.md
+settings.local.json
+worktrees/
+plans/

.claude/CLAUDE.md

@@ -31,6 +31,10 @@ make lint               # Run golangci-lint
 golangci-lint --version # Verify linter version
 ```
 
+### Formatting
+
+Always run `gofmt -w` on changed Go files after making edits to ensure proper formatting.
+
 ### Other Commands
 
 ```bash

.github/workflows/dependencies.yml

@@ -56,7 +56,7 @@ jobs:
           ref: main
           token: ${{ steps.credentials.outputs.token }}
       - name: Install Golang
-        uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
+        uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
         with:
           go-version: "stable"
       - name: Get the latest version

.github/workflows/e2e_tests.yml

@@ -22,7 +22,7 @@ jobs:
     steps:
       - name: Trigger CircleCI 'local' workflow
         if: ${{ github.event.inputs.status == 'false' }}
-        uses: promiseofcake/circleci-trigger-action@496d15304c6aa005448272c214d59928560de90c # v2.0.4
+        uses: promiseofcake/circleci-trigger-action@a72a9ff0b0c663613c13e47d53301ea55d7da5d9 # v3.0.1
         with:
           user-token: ${{ secrets.CIRCLECI_TOKEN }}
           project-slug: slackapi/slack-cli
@@ -31,7 +31,7 @@ jobs:
           payload: '{"run_local_build_test_workflow": true}'
       - name: Trigger CircleCI 'e2e' workflow
         if: ${{ github.event.inputs.status == 'true' }}
-        uses: promiseofcake/circleci-trigger-action@496d15304c6aa005448272c214d59928560de90c # v2.0.4
+        uses: promiseofcake/circleci-trigger-action@a72a9ff0b0c663613c13e47d53301ea55d7da5d9 # v3.0.1
         with:
           user-token: ${{ secrets.CIRCLECI_TOKEN }}
           project-slug: slackapi/slack-cli

.github/workflows/tests.yml

@@ -23,7 +23,7 @@ jobs:
           fetch-depth: 0
           persist-credentials: false
       - name: Set up Go
-        uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
+        uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
         with:
           go-version: "1.26.0"
       - name: Lint
@@ -55,7 +55,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Go
-        uses: actions/setup-go@7a3fe6cf4cb3a834922a1244abfce67bcef6a0c5 # v6.2.0
+        uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6.3.0
         with:
           go-version: "1.26.0"
       - name: Report health score

.gitignore

@@ -2,16 +2,14 @@
 bin/
 slack
 slack-cli
-hermes
-hermes-project*
+slack-cli.exe
 my-slack-app*
 coverage.out
 
 # Release artifacts
 .gon.hcl
 
 # Slack app files
-.hermes
 .slack/
 environments.yaml
 
@@ -39,7 +37,3 @@ package-lock.json
 
 # End to End Test files
 test-e2e
-
-# Claude Code local files
-.claude/settings.local.json
-CLAUDE.local.md

cmd/app/add.go

@@ -16,13 +16,11 @@ package app
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/slackapi/slack-cli/internal/app"
 	"github.com/slackapi/slack-cli/internal/cmdutil"
 	"github.com/slackapi/slack-cli/internal/config"
 	"github.com/slackapi/slack-cli/internal/experiment"
-	"github.com/slackapi/slack-cli/internal/logger"
 	"github.com/slackapi/slack-cli/internal/pkg/apps"
 	"github.com/slackapi/slack-cli/internal/prompts"
 	"github.com/slackapi/slack-cli/internal/shared"
@@ -186,11 +184,8 @@ func RunAddCommand(ctx context.Context, clients *shared.ClientFactory, selection
 
 	clients.Config.ManifestEnv = app.SetManifestEnvTeamVars(clients.Config.ManifestEnv, selection.App.TeamDomain, selection.App.IsDev)
 
-	// Set up event logger
-	log := newAddLogger(clients, selection.Auth.TeamDomain)
-
 	// Install dev app or prod app to a workspace
-	installedApp, installState, err := appInstall(ctx, clients, log, selection, orgGrantWorkspaceID)
+	installedApp, installState, err := appInstall(ctx, clients, selection, orgGrantWorkspaceID)
 	if err != nil {
 		return ctx, installState, types.App{}, err // pass the installState because some callers may use it to handle the error
 	}
@@ -201,74 +196,19 @@ func RunAddCommand(ctx context.Context, clients *shared.ClientFactory, selection
 	return ctx, installState, installedApp, nil
 }
 
-// newAddLogger creates a logger instance to receive event notifications
-func newAddLogger(clients *shared.ClientFactory, envName string) *logger.Logger {
-	return logger.New(
-		// OnEvent
-		func(event *logger.LogEvent) {
-			teamName := event.DataToString("teamName")
-			appName := event.DataToString("appName")
-			switch event.Name {
-			case "app_install_manifest":
-				// Ignore this event and format manifest outputs in create/update events
-			case "app_install_manifest_create":
-				_, _ = clients.IO.WriteOut().Write([]byte(style.Sectionf(style.TextSection{
-					Emoji: "books",
-					Text:  "App Manifest",
-					Secondary: []string{
-						fmt.Sprintf(`Creating app manifest for "%s" in "%s"`, appName, teamName),
-					},
-				})))
-			case "app_install_manifest_update":
-				_, _ = clients.IO.WriteOut().Write([]byte("\n" + style.Sectionf(style.TextSection{
-					Emoji: "books",
-					Text:  "App Manifest",
-					Secondary: []string{
-						fmt.Sprintf(`Updated app manifest for "%s" in "%s"`, appName, teamName),
-					},
-				})))
-			case "app_install_start":
-				_, _ = clients.IO.WriteOut().Write([]byte("\n" + style.Sectionf(style.TextSection{
-					Emoji: "house",
-					Text:  "App Install",
-					Secondary: []string{
-						fmt.Sprintf(`Installing "%s" app to "%s"`, appName, teamName),
-					},
-				})))
-			case "app_install_icon_success":
-				iconPath := event.DataToString("iconPath")
-				_, _ = clients.IO.WriteOut().Write([]byte(
-					style.SectionSecondaryf("Updated app icon: %s", iconPath),
-				))
-			case "app_install_icon_error":
-				iconError := event.DataToString("iconError")
-				_, _ = clients.IO.WriteOut().Write([]byte(
-					style.SectionSecondaryf("Error updating app icon: %s", iconError),
-				))
-			case "app_install_complete":
-				_, _ = clients.IO.WriteOut().Write([]byte(
-					style.SectionSecondaryf("Finished in %s", event.DataToString("installTime")),
-				))
-			default:
-				// Ignore the event
-			}
-		},
-	)
-}
-
 // printAddSuccess will print a list of the environments
 func printAddSuccess(clients *shared.ClientFactory, cmd *cobra.Command, appInstance types.App) error {
 	return runListCommand(cmd, clients)
 }
 
 // appInstall will install an app to a team. It supports both local and deployed app types.
-func appInstall(ctx context.Context, clients *shared.ClientFactory, log *logger.Logger, selection *prompts.SelectedApp, orgGrantWorkspaceID string) (types.App, types.InstallState, error) {
+func appInstall(ctx context.Context, clients *shared.ClientFactory, selection *prompts.SelectedApp, orgGrantWorkspaceID string) (types.App, types.InstallState, error) {
 	if selection != nil && selection.App.IsDev {
 		// Install local dev app to a team
-		installedApp, _, installState, err := appInstallDevAppFunc(ctx, clients, "", log, selection.Auth, selection.App)
+		installedApp, _, installState, err := appInstallDevAppFunc(ctx, clients, "", selection.Auth, selection.App)
 		return installedApp, installState, err
 	} else {
-		installState, installedApp, err := appInstallProdAppFunc(ctx, clients, log, selection.Auth, selection.App, orgGrantWorkspaceID)
+		installState, installedApp, err := appInstallProdAppFunc(ctx, clients, selection.Auth, selection.App, orgGrantWorkspaceID)
 		return installedApp, installState, err
 	}
 }

cmd/app/delete.go

@@ -20,7 +20,6 @@ import (
 
 	"github.com/slackapi/slack-cli/internal/cmdutil"
 	"github.com/slackapi/slack-cli/internal/iostreams"
-	"github.com/slackapi/slack-cli/internal/logger"
 	"github.com/slackapi/slack-cli/internal/pkg/apps"
 	"github.com/slackapi/slack-cli/internal/prompts"
 	"github.com/slackapi/slack-cli/internal/shared"
@@ -99,30 +98,14 @@ func RunDeleteCommand(ctx context.Context, clients *shared.ClientFactory, cmd *c
 		}
 	}
 
-	// Set up event logger and execute the command
-	log := newDeleteLogger(clients, cmd, team)
-	log.Data["appID"] = selection.App.AppID
-	env, err := apps.Delete(ctx, clients, log, team, selection.App, selection.Auth)
-
-	return env, err
-}
+	// Execute the command
+	env, teamName, err := apps.Delete(ctx, clients, team, selection.App, selection.Auth)
+	if err != nil {
+		return env, err
+	}
+	printDeleteApp(ctx, clients, selection.App.AppID, teamName)
 
-// newDeleteLogger creates a logger instance to receive event notifications
-func newDeleteLogger(clients *shared.ClientFactory, cmd *cobra.Command, envName string) *logger.Logger {
-	ctx := cmd.Context()
-	return logger.New(
-		// OnEvent
-		func(event *logger.LogEvent) {
-			appID := event.DataToString("appID")
-			teamName := event.DataToString("teamName")
-			switch event.Name {
-			case "on_apps_delete_app_success":
-				printDeleteApp(ctx, clients, appID, teamName)
-			default:
-				// Ignore the event
-			}
-		},
-	)
+	return env, nil
 }
 
 func confirmDeletion(ctx context.Context, IO iostreams.IOStreamer, app prompts.SelectedApp) (bool, error) {

cmd/app/uninstall.go

@@ -20,7 +20,6 @@ import (
 
 	"github.com/slackapi/slack-cli/internal/cmdutil"
 	"github.com/slackapi/slack-cli/internal/iostreams"
-	"github.com/slackapi/slack-cli/internal/logger"
 	"github.com/slackapi/slack-cli/internal/pkg/apps"
 	"github.com/slackapi/slack-cli/internal/prompts"
 	"github.com/slackapi/slack-cli/internal/shared"
@@ -94,30 +93,14 @@ func RunUninstallCommand(ctx context.Context, clients *shared.ClientFactory, cmd
 		}
 	}
 
-	// Set up event logger and execute the command
-	log := newUninstallLogger(clients, cmd, teamDomain)
-	log.Data["appID"] = selection.App.AppID
-	env, err := apps.Uninstall(ctx, clients, log, teamDomain, selection.App, selection.Auth)
-
-	return env, err
-}
+	// Execute the command
+	env, teamName, err := apps.Uninstall(ctx, clients, teamDomain, selection.App, selection.Auth)
+	if err != nil {
+		return env, err
+	}
+	printUninstallApp(ctx, clients, selection.App.AppID, teamName)
 
-// newUninstallLogger creates a logger instance to receive event notifications
-func newUninstallLogger(clients *shared.ClientFactory, cmd *cobra.Command, envName string) *logger.Logger {
-	ctx := cmd.Context()
-	return logger.New(
-		// OnEvent
-		func(event *logger.LogEvent) {
-			appID := event.DataToString("appID")
-			teamName := event.DataToString("teamName")
-			switch event.Name {
-			case "on_apps_uninstall_app_success":
-				printUninstallApp(ctx, clients, appID, teamName)
-			default:
-				// Ignore the event
-			}
-		},
-	)
+	return env, nil
 }
 
 func confirmUninstall(ctx context.Context, IO iostreams.IOStreamer, cmd *cobra.Command, selection prompts.SelectedApp) (bool, error) {

cmd/auth/auth_test.go

@@ -19,7 +19,6 @@ import (
 	"testing"
 
 	"github.com/slackapi/slack-cli/internal/hooks"
-	"github.com/slackapi/slack-cli/internal/logger"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/shared/types"
 	"github.com/slackapi/slack-cli/internal/slackcontext"
@@ -32,7 +31,7 @@ type listMockObject struct {
 	mock.Mock
 }
 
-func (m *listMockObject) MockListFunction(ctx context.Context, clients *shared.ClientFactory, log *logger.Logger) ([]types.SlackAuth, error) {
+func (m *listMockObject) MockListFunction(ctx context.Context, clients *shared.ClientFactory) ([]types.SlackAuth, error) {
 	args := m.Called()
 	return args.Get(0).([]types.SlackAuth), args.Error(1)
 }