Skip to content

Commit a87561b

Browse files
committed
feat: default manifest source to local for non-Deno apps
Change the default manifest source for non-Deno (Bolt) projects from ManifestSourceRemote to ManifestSourceLocal, aligning their behavior with Deno projects.
1 parent 8e4c0aa commit a87561b

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

cmd/project/init.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ func projectInitCommandRunE(clients *shared.ClientFactory, cmd *cobra.Command, a
108108

109109
// Install the project dependencies, such as .slack/ and runtime packages
110110
// Existing projects initialized always default to config.ManifestSourceLocal.
111-
// The link command will switch it to config.ManifestSourceRemote
112111
_ = create.InstallProjectDependencies(ctx, clients, projectDirPath, config.ManifestSourceLocal)
113112

114113
// Add an existing app to the project

internal/pkg/create/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,12 +521,12 @@ func InstallProjectDependencies(
521521
manifestSource = config.ManifestSourceLocal
522522
}
523523

524-
// Set non-Deno (non-ROSI) projects to ManifestSourceRemote.
524+
// Set non-Deno (non-ROSI) projects to ManifestSourceLocal.
525525
// TODO: should check if Slack hosted project, but the SDKConfig has not been initialized yet.
526526
if clients.Runtime != nil {
527527
isDenoProject := strings.Contains(strings.ToLower(clients.Runtime.Name()), "deno")
528528
if !isDenoProject {
529-
manifestSource = config.ManifestSourceRemote
529+
manifestSource = config.ManifestSourceLocal
530530
}
531531
}
532532

internal/pkg/create/create_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -432,10 +432,10 @@ func Test_Create_installProjectDependencies(t *testing.T) {
432432
`Updated config.json manifest source to "project" (local)`,
433433
},
434434
},
435-
"When non-Deno project, should set manifest source to app settings (remote)": {
435+
"When non-Deno project, should set manifest source to project (local)": {
436436
runtime: "node",
437437
expectedOutputs: []string{
438-
`Updated config.json manifest source to "app settings" (remote)`,
438+
`Updated config.json manifest source to "project" (local)`,
439439
},
440440
},
441441
}

0 commit comments

Comments
 (0)