fix: pass original app name as display name instead of title-casing kebab

Addresses review feedback — instead of converting the kebab-case
directory name to title case (which mangles names like "TIM" or
"Translator - Translate Languages"), pass the original user-provided
app name through to manifest display fields. This preserves the
user's exact casing and formatting.

Author: srtaalej

internal/app/app.go

@@ -19,15 +19,12 @@ import (
 	"fmt"
 	"path/filepath"
 	"regexp"
-	"strings"
 	"text/template"
 
 	"github.com/slackapi/slack-cli/internal/api"
 	"github.com/slackapi/slack-cli/internal/config"
 	"github.com/slackapi/slack-cli/internal/shared/types"
 	"github.com/spf13/afero"
-	"golang.org/x/text/cases"
-	"golang.org/x/text/language"
 )
 
 // Client to access the app/project
@@ -49,14 +46,8 @@ func NewClient(
 	}
 }
 
-func kebabToTitleCase(s string) string {
-	return cases.Title(language.English).String(strings.ReplaceAll(s, "-", " "))
-}
-
 // UpdateDefaultProjectFiles should update any project specific files if any
-func UpdateDefaultProjectFiles(fs afero.Fs, dirPath string, appDirName string) error {
-	displayName := kebabToTitleCase(appDirName)
-
+func UpdateDefaultProjectFiles(fs afero.Fs, dirPath string, appDirName string, displayName string) error {
 	// Files and their corresponding app name replacement functions
 	projectFiles := []struct {
 		filename string

internal/app/app_test.go

@@ -28,12 +28,14 @@ import (
 func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 	tests := map[string]struct {
 		appDirName        string
+		displayName       string
 		existingFiles     map[string]string
 		expectedFiles     map[string]string
 		expectedErrorType error
 	}{
 		"manifest.json file exists": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"manifest.json": string(testdata.ManifestJSON),
 			},
@@ -43,7 +45,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"manifest.js file exists": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"manifest.js": string(testdata.ManifestJS),
 			},
@@ -53,7 +56,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"manifest.ts file exists": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"manifest.ts": string(testdata.ManifestTS),
 			},
@@ -63,7 +67,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"Multiple manifest files exist": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"manifest.json": string(testdata.ManifestJSON),
 				"manifest.ts":   string(testdata.ManifestTS),
@@ -75,7 +80,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"package.json file exists": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"package.json": string(testdata.PackageJSON),
 			},
@@ -85,7 +91,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"pyproject.toml file exists": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"pyproject.toml": string(testdata.PyprojectTOML),
 			},
@@ -95,7 +102,8 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			expectedErrorType: nil,
 		},
 		"Multiple project files exist": {
-			appDirName: "vibrant-butterfly-1234",
+			appDirName:  "vibrant-butterfly-1234",
+			displayName: "Vibrant Butterfly 1234",
 			existingFiles: map[string]string{
 				"manifest.json":  string(testdata.ManifestJSON),
 				"package.json":   string(testdata.PackageJSON),
@@ -110,6 +118,7 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 		},
 		"No manifest files exist": {
 			appDirName:        "vibrant-butterfly-1234",
+			displayName:       "Vibrant Butterfly 1234",
 			existingFiles:     map[string]string{},
 			expectedFiles:     map[string]string{},
 			expectedErrorType: nil,
@@ -136,7 +145,7 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 			}
 
 			// Run the tests
-			err := UpdateDefaultProjectFiles(fs, projectDirPath, tc.appDirName)
+			err := UpdateDefaultProjectFiles(fs, projectDirPath, tc.appDirName, tc.displayName)
 
 			// Assertions
 			require.IsType(t, err, tc.expectedErrorType)
@@ -151,32 +160,6 @@ func Test_App_UpdateDefaultProjectFiles(t *testing.T) {
 	}
 }
 
-func Test_kebabToTitleCase(t *testing.T) {
-	tests := map[string]struct {
-		input    string
-		expected string
-	}{
-		"multiple words": {
-			input:    "my-app",
-			expected: "My App",
-		},
-		"multiple words with numbers": {
-			input:    "vibrant-butterfly-1234",
-			expected: "Vibrant Butterfly 1234",
-		},
-		"single word": {
-			input:    "hello",
-			expected: "Hello",
-		},
-	}
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			result := kebabToTitleCase(tc.input)
-			require.Equal(t, tc.expected, result)
-		})
-	}
-}
-
 func Test_RegexReplaceAppNameInManifest(t *testing.T) {
 	tests := map[string]struct {
 		src         []byte

internal/pkg/create/create.go

@@ -150,7 +150,7 @@ func Create(ctx context.Context, clients *shared.ClientFactory, createArgs Creat
 	}()
 
 	// Update default project files' app name, bot name, etc
-	if err := app.UpdateDefaultProjectFiles(clients.Fs, projectDirPath, appDirName); err != nil {
+	if err := app.UpdateDefaultProjectFiles(clients.Fs, projectDirPath, appDirName, createArgs.AppName); err != nil {
 		return "", slackerror.Wrap(err, slackerror.ErrProjectFileUpdate)
 	}