test: reorder os_test.go functions alphabetically

Author: mwbrooks

internal/slackdeps/os_test.go

@@ -21,6 +21,68 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+func Test_Os_GetExecutionDir(t *testing.T) {
+	tests := map[string]struct {
+		executionDirPathAbs         string
+		expectedExecutionDirPathAbs string
+	}{
+		"When unset should return blank": {
+			executionDirPathAbs:         "",
+			expectedExecutionDirPathAbs: "",
+		},
+		"When set should return path": {
+			executionDirPathAbs:         "/path/to/execution/dir",
+			expectedExecutionDirPathAbs: "/path/to/execution/dir",
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			// Setup
+			os := NewOs()
+			os.executionDirPathAbs = tc.executionDirPathAbs
+
+			// Run the test
+			actualExecutionDirPathAbs := os.GetExecutionDir()
+
+			// Assertions
+			require.Equal(t, tc.expectedExecutionDirPathAbs, actualExecutionDirPathAbs)
+		})
+	}
+}
+
+func Test_Os_SetExecutionDir(t *testing.T) {
+	tests := map[string]struct {
+		executionDirPathAbs         string
+		setExecutionDirPathAbs      string
+		expectedExecutionDirPathAbs string
+	}{
+		"Successful set path": {
+			executionDirPathAbs:         "",
+			setExecutionDirPathAbs:      "/path/to/execution/dir",
+			expectedExecutionDirPathAbs: "/path/to/execution/dir",
+		},
+		"Successfully overwrite path": {
+			executionDirPathAbs:         "/some/original/path",
+			setExecutionDirPathAbs:      "/path/to/execution/dir",
+			expectedExecutionDirPathAbs: "/path/to/execution/dir",
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			// Setup
+			os := NewOs()
+			os.executionDirPathAbs = tc.executionDirPathAbs
+
+			// Run the test
+			os.SetExecutionDir(tc.setExecutionDirPathAbs)
+			actualExecutionDirPathAbs := os.executionDirPathAbs
+
+			// Assertions
+			require.Equal(t, tc.expectedExecutionDirPathAbs, actualExecutionDirPathAbs)
+		})
+	}
+}
+
 func Test_Os_Getenv(t *testing.T) {
 	tests := map[string]struct {
 		key      string
@@ -48,17 +110,50 @@ func Test_Os_Getenv(t *testing.T) {
 	}
 }
 
-func Test_Os_SetenvUnsetenv(t *testing.T) {
+func Test_Os_Getwd(t *testing.T) {
 	o := NewOs()
-	key := "SLACK_TEST_OS_SETENV"
+	dir, err := o.Getwd()
+	require.NoError(t, err)
+	require.NotEmpty(t, dir)
+}
 
-	err := o.Setenv(key, "test_value")
+func Test_Os_Glob(t *testing.T) {
+	o := NewOs()
+	// Create a temp file to glob for
+	tmpDir := t.TempDir()
+	f, err := os.CreateTemp(tmpDir, "glob_test_*.txt")
 	require.NoError(t, err)
-	require.Equal(t, "test_value", o.Getenv(key))
+	f.Close()
 
-	err = o.Unsetenv(key)
+	matches, err := o.Glob(tmpDir + "/*.txt")
 	require.NoError(t, err)
-	require.Equal(t, "", o.Getenv(key))
+	require.NotEmpty(t, matches)
+}
+
+func Test_Os_IsNotExist(t *testing.T) {
+	tests := map[string]struct {
+		err      error
+		expected bool
+	}{
+		"returns true for os.ErrNotExist": {
+			err:      os.ErrNotExist,
+			expected: true,
+		},
+		"returns false for other errors": {
+			err:      os.ErrPermission,
+			expected: false,
+		},
+		"returns false for nil": {
+			err:      nil,
+			expected: false,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			o := NewOs()
+			require.Equal(t, tc.expected, o.IsNotExist(tc.err))
+		})
+	}
 }
 
 func Test_Os_LookupEnv(t *testing.T) {
@@ -96,57 +191,17 @@ func Test_Os_LookupEnv(t *testing.T) {
 	}
 }
 
-func Test_Os_Getwd(t *testing.T) {
-	o := NewOs()
-	dir, err := o.Getwd()
-	require.NoError(t, err)
-	require.NotEmpty(t, dir)
-}
-
-func Test_Os_UserHomeDir(t *testing.T) {
+func Test_Os_SetenvUnsetenv(t *testing.T) {
 	o := NewOs()
-	home, err := o.UserHomeDir()
-	require.NoError(t, err)
-	require.NotEmpty(t, home)
-}
-
-func Test_Os_IsNotExist(t *testing.T) {
-	tests := map[string]struct {
-		err      error
-		expected bool
-	}{
-		"returns true for os.ErrNotExist": {
-			err:      os.ErrNotExist,
-			expected: true,
-		},
-		"returns false for other errors": {
-			err:      os.ErrPermission,
-			expected: false,
-		},
-		"returns false for nil": {
-			err:      nil,
-			expected: false,
-		},
-	}
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			o := NewOs()
-			require.Equal(t, tc.expected, o.IsNotExist(tc.err))
-		})
-	}
-}
+	key := "SLACK_TEST_OS_SETENV"
 
-func Test_Os_Glob(t *testing.T) {
-	o := NewOs()
-	// Create a temp file to glob for
-	tmpDir := t.TempDir()
-	f, err := os.CreateTemp(tmpDir, "glob_test_*.txt")
+	err := o.Setenv(key, "test_value")
 	require.NoError(t, err)
-	f.Close()
+	require.Equal(t, "test_value", o.Getenv(key))
 
-	matches, err := o.Glob(tmpDir + "/*.txt")
+	err = o.Unsetenv(key)
 	require.NoError(t, err)
-	require.NotEmpty(t, matches)
+	require.Equal(t, "", o.Getenv(key))
 }
 
 func Test_Os_Stdout(t *testing.T) {
@@ -155,64 +210,9 @@ func Test_Os_Stdout(t *testing.T) {
 	require.NotNil(t, stdout)
 }
 
-func Test_Os_GetExecutionDir(t *testing.T) {
-	tests := map[string]struct {
-		executionDirPathAbs         string
-		expectedExecutionDirPathAbs string
-	}{
-		"When unset should return blank": {
-			executionDirPathAbs:         "",
-			expectedExecutionDirPathAbs: "",
-		},
-		"When set should return path": {
-			executionDirPathAbs:         "/path/to/execution/dir",
-			expectedExecutionDirPathAbs: "/path/to/execution/dir",
-		},
-	}
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			// Setup
-			os := NewOs()
-			os.executionDirPathAbs = tc.executionDirPathAbs
-
-			// Run the test
-			actualExecutionDirPathAbs := os.GetExecutionDir()
-
-			// Assertions
-			require.Equal(t, tc.expectedExecutionDirPathAbs, actualExecutionDirPathAbs)
-		})
-	}
-}
-
-func Test_Os_SetExecutionDir(t *testing.T) {
-	tests := map[string]struct {
-		executionDirPathAbs         string
-		setExecutionDirPathAbs      string
-		expectedExecutionDirPathAbs string
-	}{
-		"Successful set path": {
-			executionDirPathAbs:         "",
-			setExecutionDirPathAbs:      "/path/to/execution/dir",
-			expectedExecutionDirPathAbs: "/path/to/execution/dir",
-		},
-		"Successfully overwrite path": {
-			executionDirPathAbs:         "/some/original/path",
-			setExecutionDirPathAbs:      "/path/to/execution/dir",
-			expectedExecutionDirPathAbs: "/path/to/execution/dir",
-		},
-	}
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			// Setup
-			os := NewOs()
-			os.executionDirPathAbs = tc.executionDirPathAbs
-
-			// Run the test
-			os.SetExecutionDir(tc.setExecutionDirPathAbs)
-			actualExecutionDirPathAbs := os.executionDirPathAbs
-
-			// Assertions
-			require.Equal(t, tc.expectedExecutionDirPathAbs, actualExecutionDirPathAbs)
-		})
-	}
+func Test_Os_UserHomeDir(t *testing.T) {
+	o := NewOs()
+	home, err := o.UserHomeDir()
+	require.NoError(t, err)
+	require.NotEmpty(t, home)
 }