linter

Author: srtaalej

internal/api/icon.go

@@ -35,7 +35,7 @@ import (
 
 const (
 	appIconMethod = "apps.hosted.icon"
-	// AppIconSetMethod is the API method for setting app icons for non-hosted apps.
+	// appIconSetMethod is the API method for setting app icons for non-hosted apps.
 	appIconSetMethod = "apps.icon.set"
 )
 
@@ -56,7 +56,7 @@ func (c *Client) Icon(ctx context.Context, fs afero.Fs, token, appID, iconFilePa
 
 // IconSet sets a Slack App's icon using the apps.icon.set API method.
 func (c *Client) IconSet(ctx context.Context, fs afero.Fs, token, appID, iconFilePath string) (IconResult, error) {
-	return c.uploadIcon(ctx, fs, token, appID, iconFilePath, AppIconSetMethod, "icon")
+	return c.uploadIcon(ctx, fs, token, appID, iconFilePath, appIconSetMethod, "icon")
 }
 
 // uploadIcon uploads an icon to the given API method.

internal/api/icon_test.go

@@ -70,7 +70,7 @@ func TestClient_IconSetErrorIfMissingArgs(t *testing.T) {
 	ctx := slackcontext.MockContext(t.Context())
 	fs := afero.NewMemMapFs()
 	c, teardown := NewFakeClient(t, FakeClientParams{
-		ExpectedMethod: AppIconSetMethod,
+		ExpectedMethod: appIconSetMethod,
 	})
 	defer teardown()
 	_, err := c.IconSet(ctx, fs, "token", "", "")
@@ -82,7 +82,7 @@ func TestClient_IconSetErrorNoFile(t *testing.T) {
 	ctx := slackcontext.MockContext(t.Context())
 	fs := afero.NewMemMapFs()
 	c, teardown := NewFakeClient(t, FakeClientParams{
-		ExpectedMethod: AppIconSetMethod,
+		ExpectedMethod: appIconSetMethod,
 	})
 	defer teardown()
 	_, err := c.IconSet(ctx, fs, "token", "12345", imgFile)
@@ -105,7 +105,7 @@ func TestClient_IconSetErrorResponse(t *testing.T) {
 	err := png.Encode(myfile, myimage)
 	require.NoError(t, err)
 	c, teardown := NewFakeClient(t, FakeClientParams{
-		ExpectedMethod: AppIconSetMethod,
+		ExpectedMethod: appIconSetMethod,
 		Response:       `{"ok":false,"error":"invalid_app"}`,
 	})
 	defer teardown()
@@ -130,7 +130,7 @@ func TestClient_IconSetSuccess(t *testing.T) {
 	err := png.Encode(myfile, myimage)
 	require.NoError(t, err)
 	c, teardown := NewFakeClient(t, FakeClientParams{
-		ExpectedMethod: AppIconSetMethod,
+		ExpectedMethod: appIconSetMethod,
 		Response:       `{"ok":true}`,
 	})
 	defer teardown()

internal/pkg/apps/install.go

@@ -660,7 +660,7 @@ func updateIcon(ctx context.Context, clients *shared.ClientFactory, iconPath, ap
 
 	// var iconResp apiclient.IconResult
 	var err error
-	_, err = clients.API().SetIcon(ctx, clients.Fs, token, appID, iconPath)
+	_, err = clients.API().IconSet(ctx, clients.Fs, token, appID, iconPath)
 	if err != nil {
 		// TODO: separate the icon upload into a different function because if an error is returned
 		// the new app_id might be ignored and next time we'll create another app.