fix: skip automatic update check for api command with arguments (#568)

Author: zimeg

internal/update/update.go

@@ -223,8 +223,12 @@ func (u *UpdateNotification) isCI() bool {
 
 // isIgnoredCommand returns true when the process is in the list of commands.
 func (u *UpdateNotification) isIgnoredCommand() bool {
+	// Commands that skip update checks only when used alone or with flags
 	// "manifest" is included because it's an alias that runs "manifest info"
-	ignoredCommands := []string{"_fingerprint", "api", "manifest", "manifest info", "version"}
+	ignoredCommands := []string{"_fingerprint", "manifest", "manifest info", "version"}
+	// Commands that skip update checks regardless of any arguments
+	// "api" is a leaf command that accepts positional args, not subcommands
+	ignoredPrefixes := []string{"api"}
 	if len(os.Args) < 2 {
 		return false
 	}
@@ -246,6 +250,11 @@ func (u *UpdateNotification) isIgnoredCommand() bool {
 			}
 		}
 	}
+	for _, prefix := range ignoredPrefixes {
+		if commandStr == prefix || strings.HasPrefix(commandStr, prefix+" ") {
+			return true
+		}
+	}
 	return false
 }
 

internal/update/update_test.go

@@ -158,6 +158,18 @@ func Test_UpdateNotification_isIgnoredCommand(t *testing.T) {
 			command:  "api",
 			expected: true,
 		},
+		"api command with method": {
+			command:  "api chat.postMessage",
+			expected: true,
+		},
+		"api command with method and args": {
+			command:  "api chat.postMessage channel=C123 text=hello",
+			expected: true,
+		},
+		"api command with flags": {
+			command:  "api chat.postMessage --json {}",
+			expected: true,
+		},
 		"fingerprint command": {
 			command:  "_fingerprint",
 			expected: true,