Merge branch 'main' into ale-accessibility-flag

Author: srtaalej

.claude/settings.json

@@ -16,6 +16,7 @@
       "Bash(git log:*)",
       "Bash(git status:*)",
       "Bash(go build:*)",
+      "Bash(go doc:*)",
       "Bash(go mod graph:*)",
       "Bash(go mod tidy:*)",
       "Bash(go mod tidy:*)",

.github/STYLE_GUIDE.md

@@ -5,7 +5,9 @@ A current suggestion for how Slack CLI inputs are handled and outputs are format
 - **Input**
   - [Prompts are Flags with Forms](#prompts-are-flags-with-forms)
 - **Output**
-  - [Format Sections with Command Details](#format-sections-with-command-details)
+  - [Help Arguments use Opinionated Brackets](#help-arguments-use-opinionated-brackets)
+  - [Help Descriptions find Complete Sentences](#help-descriptions-find-complete-sentences)
+  - [Section Formats with Command Headings](#section-formats-with-command-headings)
 
 ## Input
 
@@ -23,7 +25,44 @@ A flag option should exist for each prompt with a form fallback. Either default
 
 Results of a command go toward informing current happenings and suggesting next steps.
 
-### Format Sections with Command Details
+### Help Arguments use Opinionated Brackets
+
+The square brackets surrounding command arguments hint that these are optional:
+
+```
+USAGE
+  $ slack env add [name] [value] [flags]
+```
+
+The angled brackets around arguments hint that these are required:
+
+```
+USAGE
+  $ slack <command>
+```
+
+Optional and required arguments can be mixed-and-matched:
+
+```
+USAGE
+  $ slack <command> [args] [flags]
+```
+
+These examples have meaningful argument placeholders and sometimes forms as fallback.
+
+### Help Descriptions find Complete Sentences
+
+The output of extended help descriptions should be complete sentences:
+
+```txt
+$ slack docs search --help
+Search the Slack developer docs and return results in text, JSON, or browser
+format.
+```
+
+This example uses punctuation and breaks lines at or before the 80 character count.
+
+### Section Formats with Command Headings
 
 A command often prints information and details about the process happenings. We format this as a section:
 

cmd/app/app.go

@@ -25,7 +25,7 @@ import (
 func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:     "app",
-		Aliases: []string{"workspace", "app", "apps", "team", "teams", "workspaces"},
+		Aliases: []string{"app", "apps"},
 		Short:   "Install, uninstall, and list teams with the app installed",
 		Long:    "Install, uninstall, and list teams with the app installed",
 		Example: style.ExampleCommandsf([]style.ExampleCommand{
@@ -45,20 +45,6 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			return runListCommand(cmd, clients)
 		},
-		PostRunE: func(cmd *cobra.Command, args []string) error {
-			ctx := cmd.Context()
-			// DEPRECATED(semver:major): remove the "workspace" alias
-			if cmd.CalledAs() == "workspace" {
-				clients.IO.PrintInfo(ctx, false,
-					"\n%s It looks like you used %s. This command will be deprecated in an upcoming release.\n    You can now use %s instead of %s.\n ",
-					style.Emoji("bulb"),
-					style.Commandf("workspace", true),
-					style.Commandf("app", true),
-					style.Commandf("workspace", true),
-				)
-			}
-			return nil
-		},
 	}
 
 	// Add child commands

cmd/app/app_test.go

@@ -24,7 +24,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func TestWorkspaceCommand(t *testing.T) {
+func TestAppCommand(t *testing.T) {
 	// Create mocks
 	ctx := slackcontext.MockContext(t.Context())
 	clientsMock := shared.NewClientsMock()

cmd/env/add.go

@@ -15,6 +15,7 @@
 package env
 
 import (
+	"context"
 	"strings"
 
 	"github.com/slackapi/slack-cli/internal/prompts"
@@ -34,28 +35,30 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:     "env <subcommand>",
 		Aliases: []string{"var", "vars", "variable", "variables"},
-		Short:   "Add, remove, or list environment variables",
+		Short:   "Set, unset, or list environment variables",
 		Long: strings.Join([]string{
-			"Add, remove, or list environment variables for apps deployed to Slack managed",
-			"infrastructure.",
+			"Set, unset, or list environment variables for the project.",
 			"",
-			"This command is supported for apps deployed to Slack managed infrastructure but",
-			"other apps can attempt to run the command with the --force flag.",
+			"Commands that run in the context of a project source environment variables from",
+			"the \".env\" file. This includes the \"run\" command.",
+			"",
+			"The \"deploy\" command gathers environment variables from the \".env\" file as well",
+			"unless the app is using ROSI features.",
 			"",
 			`Explore more: {{LinkText "https://docs.slack.dev/tools/slack-cli/guides/using-environment-variables-with-the-slack-cli"}}`,
 		}, "\n"),
 		Example: style.ExampleCommandsf([]style.ExampleCommand{
 			{
-				Meaning: "Add an environment variable",
-				Command: "env add MAGIC_PASSWORD abracadbra",
+				Meaning: "Set an environment variable",
+				Command: "env set MAGIC_PASSWORD abracadbra",
 			},
 			{
 				Meaning: "List all environment variables",
 				Command: "env list",
 			},
 			{
-				Meaning: "Remove an environment variable",
-				Command: "env remove MAGIC_PASSWORD",
+				Meaning: "Unset an environment variable",
+				Command: "env unset MAGIC_PASSWORD",
 			},
 		}),
 		RunE: func(cmd *cobra.Command, args []string) error {
@@ -64,9 +67,22 @@ func NewCommand(clients *shared.ClientFactory) *cobra.Command {
 	}
 
 	// Add child commands
-	cmd.AddCommand(NewEnvAddCommand(clients))
+	cmd.AddCommand(NewEnvSetCommand(clients))
 	cmd.AddCommand(NewEnvListCommand(clients))
-	cmd.AddCommand(NewEnvRemoveCommand(clients))
+	cmd.AddCommand(NewEnvUnsetCommand(clients))
 
 	return cmd
 }
+
+// isHostedRuntime returns true if the local manifest is for an app that uses
+// the Deno Slack SDK function runtime.
+//
+// It defaults to false when the manifest cannot be fetched, which directs the
+// command to use the project ".env" file. Otherwise the API is used.
+func isHostedRuntime(ctx context.Context, clients *shared.ClientFactory) bool {
+	manifest, err := clients.AppClient().Manifest.GetManifestLocal(ctx, clients.SDKConfig, clients.HookExecutor)
+	if err != nil {
+		return false
+	}
+	return manifest.IsFunctionRuntimeSlackHosted() || manifest.IsFunctionRuntimeLocal()
+}