refactor: remove manifestIcon param from icon.ResolveIconPath

Manifest icon handling now lives in the resolveIconPath wrapper in
install.go, so icon.ResolveIconPath only does file discovery.

Author: srtaalej

internal/icon/icon.go

@@ -20,10 +20,7 @@ import (
 	"github.com/spf13/afero"
 )
 
-func ResolveIconPath(fs afero.Fs, manifestIcon string) string {
-	if manifestIcon != "" {
-		return manifestIcon
-	}
+func ResolveIconPath(fs afero.Fs) string {
 	supportedExtensions := []string{".png", ".jpg", ".jpeg", ".gif"}
 	for _, dir := range []string{"assets", "."} {
 		for _, ext := range supportedExtensions {

internal/icon/icon_test.go

@@ -24,19 +24,9 @@ import (
 
 func Test_ResolveIconPath(t *testing.T) {
 	tests := map[string]struct {
-		manifestIcon string
-		files        []string
-		expected     string
+		files    []string
+		expected string
 	}{
-		"manifest icon set returns it directly": {
-			manifestIcon: "custom/my-icon.png",
-			expected:     "custom/my-icon.png",
-		},
-		"manifest icon preferred over magic icon files": {
-			manifestIcon: "custom/my-icon.png",
-			files:        []string{"assets/icon.png", "icon.png"},
-			expected:     "custom/my-icon.png",
-		},
 		"assets/icon.png found": {
 			files:    []string{"assets/icon.png"},
 			expected: "assets/icon.png",
@@ -84,7 +74,7 @@ func Test_ResolveIconPath(t *testing.T) {
 			for _, f := range tc.files {
 				require.NoError(t, afero.WriteFile(fs, f, []byte("img"), 0o644))
 			}
-			result := ResolveIconPath(fs, tc.manifestIcon)
+			result := ResolveIconPath(fs)
 			assert.Equal(t, tc.expected, result)
 		})
 	}