test: order test functions alphabetically and document convention

Reorder test functions added on this branch alphabetically within
their files, grouping getter/setter tests under the base name.
Document the test ordering convention in MAINTAINERS_GUIDE.md and
CLAUDE.md.

Author: mwbrooks

.claude/CLAUDE.md

@@ -144,6 +144,10 @@ func Test_Client_GetAppStatus(t *testing.T) { ... }  // struct method
 func Test_getKeyLength(t *testing.T) { ... }          // package-level function
 ```
 
+### Test Ordering Conventions
+
+Test functions should be ordered alphabetically within each file. When a file has logical sections (separated by comments), tests should be alphabetical within each section. Getter and setter functions are grouped together under the base name — ignore the `Get` or `Set` prefix when determining order (e.g. `Test_AppName` and `Test_SetAppName` both sort under `A`).
+
 ### Table-Driven Test Conventions
 
 **Preferred: Map pattern** - uses `tc` for test case variable:

.github/MAINTAINERS_GUIDE.md

@@ -397,6 +397,16 @@ func Test_Client_GetAppStatus(t *testing.T) { ... }
 func Test_getKeyLength(t *testing.T) { ... }
 ```
 
+#### Test ordering conventions
+
+Test functions should be ordered alphabetically within each file. When a file has
+logical sections (separated by comments), tests should be alphabetical within each
+section.
+
+Getter and setter functions should be grouped together under the base name. Ignore
+the `Get` or `Set` prefix when determining alphabetical order. For example,
+`Test_AppName` and `Test_SetAppName` are both sorted under `A` for `AppName`.
+
 #### Contributing tests
 
 If you'd like to add tests, please review our

internal/iostreams/iostreams_test.go

@@ -25,16 +25,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func Test_IOSteams_NewIOStreams(t *testing.T) {
-	var io *IOStreams
-	fsMock := slackdeps.NewFsMock()
-	osMock := slackdeps.NewOsMock()
-	config := config.NewConfig(fsMock, osMock)
-	config.DebugEnabled = true
-	io = NewIOStreams(config, fsMock, osMock)
-	require.True(t, io.config.DebugEnabled, "iostreams references config")
-}
-
 func Test_IOStreams_ExitCode(t *testing.T) {
 	tests := map[string]struct {
 		setCode  ExitCode
@@ -65,6 +55,16 @@ func Test_IOStreams_ExitCode(t *testing.T) {
 	}
 }
 
+func Test_IOSteams_NewIOStreams(t *testing.T) {
+	var io *IOStreams
+	fsMock := slackdeps.NewFsMock()
+	osMock := slackdeps.NewOsMock()
+	config := config.NewConfig(fsMock, osMock)
+	config.DebugEnabled = true
+	io = NewIOStreams(config, fsMock, osMock)
+	require.True(t, io.config.DebugEnabled, "iostreams references config")
+}
+
 func Test_IOStreams_IsTTY(t *testing.T) {
 	tests := map[string]struct {
 		fileInfo os.FileInfo
@@ -97,7 +97,7 @@ func Test_IOStreams_IsTTY(t *testing.T) {
 	}
 }
 
-func Test_SetCmdIO(t *testing.T) {
+func Test_IOStreams_SetCmdIO(t *testing.T) {
 	fsMock := slackdeps.NewFsMock()
 	osMock := slackdeps.NewOsMock()
 	cfg := config.NewConfig(fsMock, osMock)

internal/iostreams/survey_test.go

@@ -48,6 +48,12 @@ func Test_ConfirmPromptConfig(t *testing.T) {
 	}
 }
 
+func Test_DefaultSelectPromptConfig(t *testing.T) {
+	cfg := DefaultSelectPromptConfig()
+	assert.True(t, cfg.IsRequired())
+	assert.Empty(t, cfg.GetFlags())
+}
+
 func Test_InputPromptConfig(t *testing.T) {
 	tests := map[string]struct {
 		cfg      InputPromptConfig
@@ -110,58 +116,6 @@ func Test_PasswordPromptConfig(t *testing.T) {
 	})
 }
 
-func Test_SelectPromptConfig(t *testing.T) {
-	t.Run("no flags", func(t *testing.T) {
-		cfg := SelectPromptConfig{Required: true}
-		assert.True(t, cfg.IsRequired())
-		assert.Empty(t, cfg.GetFlags())
-	})
-	t.Run("single flag", func(t *testing.T) {
-		var val string
-		fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
-		fs.StringVar(&val, "app", "", "app flag")
-		flag := fs.Lookup("app")
-		cfg := SelectPromptConfig{Flag: flag}
-		assert.Len(t, cfg.GetFlags(), 1)
-	})
-	t.Run("multiple flags", func(t *testing.T) {
-		var v1, v2 string
-		fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
-		fs.StringVar(&v1, "a", "", "")
-		fs.StringVar(&v2, "b", "", "")
-		cfg := SelectPromptConfig{Flags: []*pflag.Flag{fs.Lookup("a"), fs.Lookup("b")}}
-		assert.Len(t, cfg.GetFlags(), 2)
-	})
-}
-
-func Test_SurveyOptions(t *testing.T) {
-	tests := map[string]struct {
-		cfg         PromptConfig
-		expectedLen int
-	}{
-		"required config returns 5 options": {
-			cfg:         ConfirmPromptConfig{Required: true},
-			expectedLen: 5,
-		},
-		"optional config returns 5 options": {
-			cfg:         ConfirmPromptConfig{Required: false},
-			expectedLen: 5,
-		},
-	}
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			opts := SurveyOptions(tc.cfg)
-			assert.Len(t, opts, tc.expectedLen)
-		})
-	}
-}
-
-func Test_DefaultSelectPromptConfig(t *testing.T) {
-	cfg := DefaultSelectPromptConfig()
-	assert.True(t, cfg.IsRequired())
-	assert.Empty(t, cfg.GetFlags())
-}
-
 func Test_retrieveFlagValue(t *testing.T) {
 	fsMock := slackdeps.NewFsMock()
 	osMock := slackdeps.NewOsMock()
@@ -234,6 +188,52 @@ func Test_retrieveFlagValue(t *testing.T) {
 	}
 }
 
+func Test_SelectPromptConfig(t *testing.T) {
+	t.Run("no flags", func(t *testing.T) {
+		cfg := SelectPromptConfig{Required: true}
+		assert.True(t, cfg.IsRequired())
+		assert.Empty(t, cfg.GetFlags())
+	})
+	t.Run("single flag", func(t *testing.T) {
+		var val string
+		fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
+		fs.StringVar(&val, "app", "", "app flag")
+		flag := fs.Lookup("app")
+		cfg := SelectPromptConfig{Flag: flag}
+		assert.Len(t, cfg.GetFlags(), 1)
+	})
+	t.Run("multiple flags", func(t *testing.T) {
+		var v1, v2 string
+		fs := pflag.NewFlagSet("test", pflag.ContinueOnError)
+		fs.StringVar(&v1, "a", "", "")
+		fs.StringVar(&v2, "b", "", "")
+		cfg := SelectPromptConfig{Flags: []*pflag.Flag{fs.Lookup("a"), fs.Lookup("b")}}
+		assert.Len(t, cfg.GetFlags(), 2)
+	})
+}
+
+func Test_SurveyOptions(t *testing.T) {
+	tests := map[string]struct {
+		cfg         PromptConfig
+		expectedLen int
+	}{
+		"required config returns 5 options": {
+			cfg:         ConfirmPromptConfig{Required: true},
+			expectedLen: 5,
+		},
+		"optional config returns 5 options": {
+			cfg:         ConfirmPromptConfig{Required: false},
+			expectedLen: 5,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			opts := SurveyOptions(tc.cfg)
+			assert.Len(t, opts, tc.expectedLen)
+		})
+	}
+}
+
 func TestPasswordPrompt(t *testing.T) {
 	tests := map[string]struct {
 		FlagChanged   bool

internal/iostreams/writer_test.go

@@ -199,6 +199,15 @@ func Test_FilteredWriter(t *testing.T) {
 	}
 }
 
+func Test_WriteErr(t *testing.T) {
+	fsMock := slackdeps.NewFsMock()
+	osMock := slackdeps.NewOsMock()
+	cfg := config.NewConfig(fsMock, osMock)
+	io := NewIOStreams(cfg, fsMock, osMock)
+	w := io.WriteErr()
+	require.NotNil(t, w)
+}
+
 func Test_WriteIndent(t *testing.T) {
 	tests := map[string]struct {
 		input    string
@@ -242,15 +251,6 @@ func Test_WriteOut(t *testing.T) {
 	require.NotNil(t, w)
 }
 
-func Test_WriteErr(t *testing.T) {
-	fsMock := slackdeps.NewFsMock()
-	osMock := slackdeps.NewOsMock()
-	cfg := config.NewConfig(fsMock, osMock)
-	io := NewIOStreams(cfg, fsMock, osMock)
-	w := io.WriteErr()
-	require.NotNil(t, w)
-}
-
 func Test_WriteSecondary(t *testing.T) {
 	tests := map[string]struct {
 		input     string

internal/style/format_test.go

@@ -24,6 +24,35 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+func Test_Commandf(t *testing.T) {
+	tests := map[string]struct {
+		process   string
+		command   string
+		isPrimary bool
+	}{
+		"primary command contains process and command": {
+			process:   "renamed-slack-command",
+			command:   "feedback",
+			isPrimary: true,
+		},
+		"secondary command contains process and command": {
+			process:   "a-renamed-slack-cli",
+			command:   "feedback",
+			isPrimary: false,
+		},
+	}
+	for name, tc := range tests {
+		t.Run(name, func(t *testing.T) {
+			processTemp := os.Args[0]
+			os.Args[0] = tc.process
+			defer func() { os.Args[0] = processTemp }()
+
+			formatted := Commandf(tc.command, tc.isPrimary)
+			assert.Contains(t, formatted, tc.process+" "+tc.command)
+		})
+	}
+}
+
 func Test_getKeyLength(t *testing.T) {
 	tests := map[string]struct {
 		keys     map[string]string
@@ -53,6 +82,12 @@ func Test_getKeyLength(t *testing.T) {
 	}
 }
 
+func TestIndent(t *testing.T) {
+	text := "a few spaces are expected at the start of this line, but no other changes"
+	indented := Indent(text)
+	assert.Contains(t, indented, text)
+}
+
 func Test_Sectionf(t *testing.T) {
 	tests := map[string]struct {
 		section  TextSection
@@ -130,41 +165,29 @@ func Test_SectionSecondaryf(t *testing.T) {
 	}
 }
 
-func Test_Commandf(t *testing.T) {
+func TestSurveyIcons(t *testing.T) {
 	tests := map[string]struct {
-		process   string
-		command   string
-		isPrimary bool
+		styleEnabled bool
 	}{
-		"primary command contains process and command": {
-			process:   "renamed-slack-command",
-			command:   "feedback",
-			isPrimary: true,
+		"styles are not enabled": {
+			styleEnabled: false,
 		},
-		"secondary command contains process and command": {
-			process:   "a-renamed-slack-cli",
-			command:   "feedback",
-			isPrimary: false,
+		"styles are enabled": {
+			styleEnabled: true,
 		},
 	}
+
 	for name, tc := range tests {
 		t.Run(name, func(t *testing.T) {
-			processTemp := os.Args[0]
-			os.Args[0] = tc.process
-			defer func() { os.Args[0] = processTemp }()
+			core.DisableColor = false
+			isStyleEnabled = tc.styleEnabled
 
-			formatted := Commandf(tc.command, tc.isPrimary)
-			assert.Contains(t, formatted, tc.process+" "+tc.command)
+			_ = SurveyIcons()
+			assert.NotEqual(t, tc.styleEnabled, core.DisableColor)
 		})
 	}
 }
 
-func TestIndent(t *testing.T) {
-	text := "a few spaces are expected at the start of this line, but no other changes"
-	indented := Indent(text)
-	assert.Contains(t, indented, text)
-}
-
 func TestTracef(t *testing.T) {
 	tests := map[string]struct {
 		traceID     string
@@ -199,29 +222,6 @@ func TestTracef(t *testing.T) {
 	}
 }
 
-func TestSurveyIcons(t *testing.T) {
-	tests := map[string]struct {
-		styleEnabled bool
-	}{
-		"styles are not enabled": {
-			styleEnabled: false,
-		},
-		"styles are enabled": {
-			styleEnabled: true,
-		},
-	}
-
-	for name, tc := range tests {
-		t.Run(name, func(t *testing.T) {
-			core.DisableColor = false
-			isStyleEnabled = tc.styleEnabled
-
-			_ = SurveyIcons()
-			assert.NotEqual(t, tc.styleEnabled, core.DisableColor)
-		})
-	}
-}
-
 /*
 * Example commands
  */