-
Notifications
You must be signed in to change notification settings - Fork 34
feat: add 'create agent' command #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,94 @@ func TestCreateCommand(t *testing.T) { | |
| createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything, expected) | ||
| }, | ||
| }, | ||
| "creates an agent app using agent argument shortcut": { | ||
| CmdArgs: []string{"agent"}, | ||
| Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) { | ||
| // Should skip category prompt and go directly to language selection | ||
| cm.IO.On("SelectPrompt", mock.Anything, "Select a language:", mock.Anything, mock.Anything). | ||
| Return( | ||
| iostreams.SelectPromptResponse{ | ||
| Prompt: true, | ||
| Index: 0, // Select Node.js template | ||
| }, | ||
| nil, | ||
| ) | ||
| createClientMock = new(CreateClientMock) | ||
| createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", nil) | ||
| CreateFunc = createClientMock.Create | ||
| }, | ||
| ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) { | ||
| template, err := create.ResolveTemplateURL("slack-samples/bolt-js-assistant-template") | ||
| require.NoError(t, err) | ||
| expected := create.CreateArgs{ | ||
| Template: template, | ||
| } | ||
| createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything, expected) | ||
| // Verify that category prompt was NOT called | ||
| cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select an app:", mock.Anything, mock.Anything) | ||
| }, | ||
| }, | ||
| "creates an agent app with app name using agent argument": { | ||
| CmdArgs: []string{"agent", "my-agent-app"}, | ||
| Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) { | ||
| // Should skip category prompt and go directly to language selection | ||
| cm.IO.On("SelectPrompt", mock.Anything, "Select a language:", mock.Anything, mock.Anything). | ||
| Return( | ||
| iostreams.SelectPromptResponse{ | ||
| Prompt: true, | ||
| Index: 1, // Select Python template | ||
| }, | ||
| nil, | ||
| ) | ||
| createClientMock = new(CreateClientMock) | ||
| createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", nil) | ||
| CreateFunc = createClientMock.Create | ||
| }, | ||
| ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) { | ||
| template, err := create.ResolveTemplateURL("slack-samples/bolt-python-assistant-template") | ||
| require.NoError(t, err) | ||
| expected := create.CreateArgs{ | ||
| AppName: "my-agent-app", | ||
| Template: template, | ||
| } | ||
| createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything, expected) | ||
| // Verify that category prompt was NOT called | ||
| cm.IO.AssertNotCalled(t, "SelectPrompt", mock.Anything, "Select an app:", mock.Anything, mock.Anything) | ||
| }, | ||
| }, | ||
| "creates an app named agent when template flag is provided": { | ||
| CmdArgs: []string{"agent", "--template", "slack-samples/bolt-js-starter-template"}, | ||
| Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) { | ||
| cm.IO.On("SelectPrompt", mock.Anything, "Select an app:", mock.Anything, mock.Anything). | ||
| Return( | ||
| iostreams.SelectPromptResponse{ | ||
| Flag: true, | ||
| Option: "slack-samples/bolt-js-starter-template", | ||
| }, | ||
| nil, | ||
| ) | ||
| cm.IO.On("SelectPrompt", mock.Anything, "Select a language:", mock.Anything, mock.Anything). | ||
| Return( | ||
| iostreams.SelectPromptResponse{ | ||
| Flag: true, | ||
| Option: "slack-samples/bolt-js-starter-template", | ||
| }, | ||
| nil, | ||
| ) | ||
| createClientMock = new(CreateClientMock) | ||
| createClientMock.On("Create", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return("", nil) | ||
| CreateFunc = createClientMock.Create | ||
| }, | ||
| ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) { | ||
| template, err := create.ResolveTemplateURL("slack-samples/bolt-js-starter-template") | ||
| require.NoError(t, err) | ||
| expected := create.CreateArgs{ | ||
| AppName: "agent", | ||
| Template: template, | ||
| } | ||
| createClientMock.AssertCalled(t, "Create", mock.Anything, mock.Anything, mock.Anything, expected) | ||
| }, | ||
| }, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Thoughts on adding a test for the use-case |
||
| }, func(cf *shared.ClientFactory) *cobra.Command { | ||
| return NewCreateCommand(cf) | ||
| }) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This is a clever way to handle the edge-case. Personally, I start to get confused when
slack create agentwill name my app "agent" vs show me a prompt.I wonder if a more obvious approach (for the simple minded folks like me) would be anytime
slack create agentis used, it's focused on the agent prompt.The drawback to my suggestion is that we'd eventually need to introduce a
--nameflag to allow people to customize their app, such asslack create --name agent --template <url>.I'm okay moving forward with the current approach if it makes sense to @srtaalej and @zimeg. It comes down to personal choice.