fix: separate inputs for more framework and agent adapter options#479
fix: separate inputs for more framework and agent adapter options#479
Conversation
zimeg
added
bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 71.19% 71.23% +0.04%
==========================================
Files 222 222
Lines 18595 18664 +69
==========================================
+ Hits 13238 13295 +57
- Misses 4178 4189 +11
- Partials 1179 1180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "slack-cli#ai-apps": { | ||
| { | ||
| Title: fmt.Sprintf("Support Agent %s", style.Secondary("Resolve IT support cases")), | ||
| Repository: "slack-cli#ai-apps/support-agent", | ||
| }, | ||
| { | ||
| Title: fmt.Sprintf("Starter Agent %s", style.Secondary("Start from scratch")), | ||
| Repository: "slack-cli#ai-apps/starter-agent", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
suggestion: I think we should re-order this so that the Starter Agent is first, similar to the slack create experience:
┃ Select a template:
┃ ❱ Starter Agent Start from scratch
┃ Support Agent Resolve IT support cases| "slack-cli#ai-apps/support-agent": { | ||
| { | ||
| Title: fmt.Sprintf("Claude Agent SDK %s", style.Secondary("Bolt for Python")), | ||
| Title: fmt.Sprintf("Bolt for JavaScript %s", style.Secondary("Node.js")), |
There was a problem hiding this comment.
question: We originally brainstormed having the Secondary display the breadcrumb of the previous selection. I'm just curious why you decided to not include that?
| adapterPromptObjects := map[string][]promptObject{ | ||
| "slack-cli#ai-apps/support-agent/bolt-js": { | ||
| { | ||
| Title: "Claude Agent SDK", |
There was a problem hiding this comment.
question: Why don't these have any Secondary text? To me, it feels a little off that these offer no hints or additional descriptions.
| for i, opt := range adapters { | ||
| adapterChoices[i] = opt.Title | ||
| } | ||
| adapterSelection, err := clients.IO.SelectPrompt(ctx, "Select an adapter:", adapterChoices, iostreams.SelectPromptConfig{ |
There was a problem hiding this comment.
question: Why did you choose the term "adapter"? My concern is that "receiver" and "adapter" in Bolt Slack App development and these are not receivers or adapters.
I'd prefer a term such as "Select an agent framework:" or if we must keep it general then "Select a third-party framework:"
2 participants
Changelog
Summary
This PR fixes the
slack create agentcommand prompts with separate inputs for more framework and agent adapter options. This includes the following templates now:Getting started
Support agent
Starter agent
Automation apps
Preview
create.mov
Reviewers
Confirm the expected options appear with the following commands:
Requirements