test: support fish deploy hook checks#561
Draft
Muhtasham wants to merge 1 commit into
Draft
Conversation
|
Thanks for the contribution! Before we can merge this, we need @Muhtasham to sign the Salesforce Inc. Contributor License Agreement. |
Muhtasham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
Fixes #462 by making the deploy hook test expectations work when the test process runs with
SHELLset to fish.The stderr hook case now uses redirection syntax that works in fish and POSIX-like shells, and the missing deployer case accepts fish's
Unknown commandwording in addition to the existing shell-specific messages.Validation
PATH="/opt/homebrew/bin:$PATH" SHELL=/opt/homebrew/bin/fish go test ./cmd/platform -count=1PATH="/opt/homebrew/bin:$PATH" SHELL=/bin/bash go test ./cmd/platform -count=1PATH="/opt/homebrew/bin:$PATH" SHELL=/opt/homebrew/bin/fish go test ./...Requirements