Skip to content

ci: adds workflow that calls composite action for docs sync#426

Closed
lukegalbraithrussell wants to merge 2 commits into
mainfrom
ci-docs-composite-action
Closed

ci: adds workflow that calls composite action for docs sync#426
lukegalbraithrussell wants to merge 2 commits into
mainfrom
ci-docs-composite-action

Conversation

@lukegalbraithrussell
Copy link
Copy Markdown
Contributor

Summary

Composite action PR isn't merged yet though

Requirements (place an x in each [ ])

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (d07fadf) to head (fb42aae).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files           7        7           
  Lines         702      702           
=======================================
  Hits          701      701           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg zimeg added docs Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Apr 4, 2025
@zimeg zimeg added this to the 2.x milestone Apr 4, 2025
Copy link
Copy Markdown
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukegalbraithrussell Following some discussion elsewhere I'm requesting changes here to prefer a reusable workflow.

These are both new and interesting to me and I hope promising for the changes being made 👾

Please know I am excited for this to make it to main and don't mean to be a blocker!

Comment thread .github/workflows/sync-docs.yml Outdated
run: |
echo "Pull request created: ${{ steps.site-pr.outputs.pull-request-url }}" >> $GITHUB_STEP_SUMMARY
- name: Run sync-docs action
uses: ./docs_repo/.github/actions/sync-from-tools-docs No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 Using a composite action from the upstream repo checked out above is fascinating!

With the secrets needed for this workflow to work, we might want to change this to a reusable workflow instead. Reference.

This should let use the same or similar steps here and elsewhere I hope, but I am so open to testing this more somehow soon 🚀

@lukegalbraithrussell
Copy link
Copy Markdown
Contributor Author

closing this because we have better ideas for syncing

@zimeg zimeg deleted the ci-docs-composite-action branch June 20, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants