Skip to content

Docs: Updated install instructions and manifest update details#456

Closed
slackapi[bot] wants to merge 1 commit intomainfrom
docs-automated-sync-pr-132
Closed

Docs: Updated install instructions and manifest update details#456
slackapi[bot] wants to merge 1 commit intomainfrom
docs-automated-sync-pr-132

Conversation

@slackapi
Copy link
Copy Markdown
Contributor

@slackapi slackapi Bot commented Jun 9, 2025

Automated changes by create-pull-request GitHub action

@slackapi slackapi Bot added the docs Improvements or additions to documentation label Jun 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (6e4ac77) to head (4efe292).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files           7        7           
  Lines         709      709           
=======================================
  Hits          708      708           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we want to merge this. It appears to be undoing the changes from PR #447

payload: |
channel: ${{ secrets.SLACK_CHANNEL_ID }}
text: "howdy <!channel>!"
text: "howdy <@channel>!"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haleychaas I could be wrong, but I think the correct syntax is <!channel> 🤔
https://api.slack.com/reference/surfaces/formatting#special-mentions

I recently fixed this same issue in #447 so, I don't think we want to undo that change.

@zimeg zimeg added the wontfix This will not be worked on label Jun 11, 2025
@zimeg
Copy link
Copy Markdown
Member

zimeg commented Jun 11, 2025

@mwbrooks Good catch! I kicked off a run to sync docs upstream and will merge the related change to avoid these PRs from happening again.

I do think another approach might be soon best though 📚 ✨

@zimeg zimeg closed this Jun 11, 2025
@zimeg zimeg deleted the docs-automated-sync-pr-132 branch June 11, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants