Allow nonceEnabled and hashEnabled to take single boolean values#101
Open
StephanBijzitter wants to merge 1 commit intoslackhq:masterfrom
Open
Allow nonceEnabled and hashEnabled to take single boolean values#101StephanBijzitter wants to merge 1 commit intoslackhq:masterfrom
StephanBijzitter wants to merge 1 commit intoslackhq:masterfrom
Conversation
|
|
Author
|
I haven't written any new tests as the existing tests already cover this functionality because of my change to the default values. If wanted, I could add specific test-cases to handle the 4 shorthand values. |
Providing a single boolean value to either of these options will now apply the value to each provided policy directive. Closes slackhq#98
StephanBijzitter
force-pushed
the
config-shorthand
branch
from
871d133 to
1be6906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Providing a single boolean value to either of these options will now apply
the value to each provided policy directive.
Closes #98
Requirements (place an
xin each[ ])