Fix broken font embed URLs#3
Open
tamasys wants to merge 1 commit into
Open
Conversation
…values
Google Fonts css2 endpoint requires semicolons between weight values
(e.g. wght@400;700), not commas (the old css API syntax).
Root cause: the defaults in generate_typography_system used comma-separated
weight strings. Fixed those defaults, plus added defensive .replace(',', ';')
in generate_embed for any callers that pass malformed input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Description
Agents using the mcp tools generate broken Google Fonts embed URLs. The generated URLs use the
css2endpoint but provide axis values with commas (the oldcssAPI syntax) instead of semicolons.Fix
Replaced commas with semicolons in hardcoded weight values, added validation and error messages for agents so they can recover from failure. Added parsing of italic weight variants.