Skip to content

fix: resolve snippets in magic move blocks#2590

Open
cyphercodes wants to merge 1 commit into
slidevjs:mainfrom
cyphercodes:fix/magic-move-snippet-imports-2586
Open

fix: resolve snippets in magic move blocks#2590
cyphercodes wants to merge 1 commit into
slidevjs:mainfrom
cyphercodes:fix/magic-move-snippet-imports-2586

Conversation

@cyphercodes
Copy link
Copy Markdown
Contributor

Fixes #2586.

Summary

  • Resolve snippet imports inside md magic-move blocks before validating inner code blocks.
  • Reuse the existing snippet import resolver so imported files, regions, languages, metadata, and watch files stay consistent.
  • Add a regression test covering magic move with snippet inclusions.

Tests

  • corepack pnpm vitest run packages/slidev/node/syntax/codeblock/magic-move.test.ts
  • corepack pnpm vitest run packages/slidev/node/syntax/snippet.test.ts packages/slidev/node/syntax/integration.test.ts packages/slidev/node/syntax/codeblock/magic-move.test.ts --testTimeout 20000
  • corepack pnpm eslint packages/slidev/node/syntax/snippet.ts packages/slidev/node/syntax/codeblock/magic-move.ts packages/slidev/node/syntax/codeblock/magic-move.test.ts
  • corepack pnpm --filter @slidev/cli... build
  • git diff --check

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit c4e73b0
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/69fd5b44de0d9b00082ed89f
😎 Deploy Preview https://deploy-preview-2590--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 8, 2026

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/@slidev/client@2590

create-slidev

npm i https://pkg.pr.new/create-slidev@2590

create-slidev-theme

npm i https://pkg.pr.new/create-slidev-theme@2590

@slidev/parser

npm i https://pkg.pr.new/@slidev/parser@2590

@slidev/cli

npm i https://pkg.pr.new/@slidev/cli@2590

@slidev/types

npm i https://pkg.pr.new/@slidev/types@2590

commit: c4e73b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Magic Move with code snippets inclusions fails since v52.15.0

2 participants