Skip to content

fix: video having no duration (with ts-ebml dependency from GitHub)#491

Closed
marob wants to merge 1 commit into
slidevjs:mainfrom
marob:fix-video-having-no-duration-ts-ebml
Closed

fix: video having no duration (with ts-ebml dependency from GitHub)#491
marob wants to merge 1 commit into
slidevjs:mainfrom
marob:fix-video-having-no-duration-ts-ebml

Conversation

@marob
Copy link
Copy Markdown
Contributor

@marob marob commented Feb 18, 2022

When recording the presentation, the resulting video is corrupted as the duration is not/incorrectly detected by video players.

This issue explains the problem and gives a solution: we have to wrap the blob in getSeekableBlob function.

An important thing to note is that getSeekableBlob function requires EBML as dependency.

I have developed several PR solving the problem and using different ways to import EBML as each of them have pros and cons.

This PR imports ts-ebml dependency from GitHub URL. It's using a fork of the original repository as it's using code from a PR that is not merged yet

Cons: we use GitHub dependency (not a good practice?) and from a fork

See other PRs:

N.B.: adds ts-ebml dependency (from a fork as the corresponding PR is not merged yet: legokichi/ts-ebml#38)
@marob marob force-pushed the fix-video-having-no-duration-ts-ebml branch from ffb5efd to 5b2e8d8 Compare February 18, 2022 17:44
@antfu
Copy link
Copy Markdown
Member

antfu commented Feb 22, 2022

If ts-ebml is no longer actively maintained, I am wonder if anyone would like to make a fork with the fix and publish it to npm. That way would be better to install from GitHub.

@antfu
Copy link
Copy Markdown
Member

antfu commented Sep 12, 2022

Thanks but I'd prefer to have this fixed upstream.

@antfu antfu closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants