Skip to content

Commit 263a1b8

Browse files
committed
changelog in docs updated and styling for contributing page fixed
1 parent 1829e26 commit 263a1b8

3 files changed

Lines changed: 97 additions & 38 deletions

File tree

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,13 @@
5252
- Added `TYPE_CHECKING` conditional imports for matplotlib Figure type
5353
- Fixed `**kwargs` type annotations across multiple modules
5454

55+
- Numbered list formatting in `docs/about/contribution.md`:
56+
- Fixed list continuation by using 4-space indentation for code blocks and nested lists
57+
- Disabled format on save for Markdown files in `.vscode/settings.json`
58+
59+
- GitHub Actions CI disk space issue:
60+
- Added `--no-cache-dir` flag to pip install to reduce disk usage
61+
5562
### Changed
5663

5764
- README badges section converted from HTML to markdown format for better compatibility across platforms.

docs/about/changelog.md

Lines changed: 53 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,66 @@
22

33
### Added
44

5+
- New parameter `apply_advanced_cleaning` added to data cleaning methods in `data_cleaner.py`. When set to `True`, it triggers the advanced cleaning pipeline.
6+
7+
- Advanced composition cleaning methods in `data_cleaner.py`:
8+
9+
- `_remove_miller_indices()` - Removes crystal plane notations from chemical formulas
10+
- `_remove_zero_coefficient_elements()` - Removes elements with zero coefficients
11+
- `_normalize_coefficients()` - Removes trailing zeros from coefficients
12+
- `_expand_leading_and_trailing_coefficients()` - Expands leading/trailing coefficient patterns
13+
- `_expand_parenthetical_coefficients()` - Expands nested bracket coefficients
14+
15+
- Enhanced documentation in `docs/usage/data-cleaning.md`:
16+
17+
- Added `apply_advanced_cleaning` parameter documentation
18+
- Added Mermaid process flow diagram showing cleaning stages
19+
- Added advanced cleaning examples with tables for each transformation type
20+
21+
- Template for GitHub issues added to [.github/ISSUE_TEMPLATE](https://github.com/slimeslab/ComProScanner/tree/main/.github/ISSUE_TEMPLATE) for the following topics:
22+
23+
- bug reports
24+
- feature requests
25+
- documentation improvements
26+
- support questions
27+
528
- [Changelog page](https://slimeslab.github.io/ComProScanner/about/changelog/) added in the documentation. Also, [CHANGELOG.md](https://github.com/slimeslab/ComProScanner/blob/main/CHANGELOG.md) linked in [README.md](https://github.com/slimeslab/ComProScanner/blob/main/README.md).
629

7-
- Added DeepWiki integration badge to README.md for community Q&A support: [Ask DeepWiki](https://deepwiki.com/slimeslab/ComProScanner)
8-
- Added arXiv preprint badge to README.md: [arXiv:2510.20362](https://arxiv.org/abs/2510.20362)
30+
- DeepWiki integration badge added to README.md for community Q&A support:
31+
32+
- [Ask DeepWiki](https://deepwiki.com/slimeslab/ComProScanner)
33+
34+
- arXiv preprint badge added to README.md:
35+
36+
- [arXiv:2510.20362](https://arxiv.org/abs/2510.20362)
937

1038
- [CITATION.cff](https://github.com/slimeslab/ComProScanner/blob/main/CITATION.cff) added for standardized citation information based on the latest release and arXiv preprint.
1139

40+
### Fixed
41+
42+
- CSV progress tracking in `elsevier_processor.py`:
43+
44+
- DtypeWarning resolved by adding `dtype=str, low_memory=False` to `pd.read_csv()`
45+
- Data loss issue fixed with immediate CSV persistence for processed articles
46+
- Sleep delays optimized for batch writes
47+
48+
- Type annotation warnings in documentation build (griffe/mkdocstrings):
49+
- Added return type annotations to function signatures in `comproscanner.py`
50+
- Added return type annotations to all visualization functions in `data_visualizer.py` and `eval_visualizer.py`
51+
- Fixed parameter type format in docstrings from colon to comma notation
52+
- Added `TYPE_CHECKING` conditional imports for matplotlib Figure type
53+
- Fixed `**kwargs` type annotations across multiple modules
54+
55+
- Numbered list formatting in `docs/about/contribution.md`:
56+
- Fixed list continuation by using 4-space indentation for code blocks and nested lists
57+
- Disabled format on save for Markdown files in `.vscode/settings.json`
58+
59+
- GitHub Actions CI disk space issue:
60+
- Added `--no-cache-dir` flag to pip install to reduce disk usage
61+
1262
### Changed
1363

14-
- Moved the README badges section from html `p` tags to markdown format for better compatibility across platforms.
64+
- README badges section converted from HTML to markdown format for better compatibility across platforms.
1565

1666
## [0.1.4] - 02-12-2025
1767

docs/about/contribution.md

Lines changed: 37 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -35,43 +35,44 @@ There are several ways to contribute to ComProScanner:
3535
### Setting Up Development Environment
3636

3737
1. Fork the repository on GitHub
38+
3839
2. Clone your fork locally:
3940

40-
```bash
41-
git clone https://github.com/slimeslab/ComProScanner.git
42-
cd comproscanner
43-
```
41+
```bash
42+
git clone https://github.com/slimeslab/ComProScanner.git
43+
cd comproscanner
44+
```
4445

4546
3. Create a virtual environment:
4647

47-
```bash
48-
python -m venv venv
49-
source venv/bin/activate # On Windows: venv\Scripts\activate
50-
```
48+
```bash
49+
python -m venv venv
50+
source venv/bin/activate # On Windows: venv\Scripts\activate
51+
```
5152

5253
4. Install dependencies:
5354

54-
```bash
55-
pip install -e ".[dev]"
56-
```
55+
```bash
56+
pip install -e ".[dev]"
57+
```
5758

5859
5. Create a `.env` file based on `.env.example`:
5960

60-
```bash
61-
cp .env.example .env
62-
```
61+
```bash
62+
cp .env.example .env
63+
```
6364

6465
6. Add your API keys to the `.env` file
6566

6667
## Development Workflow
6768

6869
1. Create a new branch for your feature or bugfix:
6970

70-
```bash
71-
git checkout -b feature/your-feature-name
72-
# or
73-
git checkout -b fix/your-bugfix-name
74-
```
71+
```bash
72+
git checkout -b feature/your-feature-name
73+
# or
74+
git checkout -b fix/your-bugfix-name
75+
```
7576

7677
2. Make your changes
7778

@@ -81,9 +82,9 @@ There are several ways to contribute to ComProScanner:
8182

8283
5. Push to your fork:
8384

84-
```bash
85-
git push origin feature/your-feature-name
86-
```
85+
```bash
86+
git push origin feature/your-feature-name
87+
```
8788

8889
6. Submit a pull request
8990

@@ -136,27 +137,28 @@ Fixes #456
136137

137138
1. **Before submitting**, ensure:
138139

139-
- All tests pass
140-
- Code is formatted and linted
141-
- Documentation is updated
142-
- No merge conflicts with main branch
140+
- All tests pass
141+
- Code is formatted and linted
142+
- Documentation is updated
143+
- No merge conflicts with main branch
143144

144145
2. **PR Description** should include:
145146

146-
- Clear description of changes
147-
- Related issue numbers (e.g., "Closes #123")
148-
- Screenshots (if applicable)
149-
- Breaking changes (if any)
147+
- Clear description of changes
148+
- Related issue numbers (e.g., "Closes #123")
149+
- Screenshots (if applicable)
150+
- Breaking changes (if any)
150151

151152
3. **Review Process**:
152153

153-
- At least one maintainer review is required
154-
- Address all review comments
155-
- Keep discussions focused and respectful
154+
- At least one maintainer review is required
155+
- Address all review comments
156+
- Keep discussions focused and respectful
156157

157158
4. **After Approval**:
158-
- Maintainers will merge your PR
159-
- Your contribution will be credited
159+
160+
- Maintainers will merge your PR
161+
- Your contribution will be credited
160162

161163
## Reporting Bugs
162164

0 commit comments

Comments
 (0)