fix: prevent tracking file from leaking between tests

Author: aritraroy24

tests/test_article_processors/test_pdfs_processor.py

@@ -32,6 +32,20 @@ def pdfs_processor(sample_property_keywords):
         property_keywords=sample_property_keywords,
         is_sql_db=False,
         csv_batch_size=10,
+        is_track_pdfs=False,
+    )
+
+
+@pytest.fixture
+def pdfs_processor_with_tracking(sample_property_keywords):
+    """Fixture with PDF tracking enabled for tracking-specific tests"""
+    return PDFsProcessor(
+        folder_path="/test/path",
+        main_property_keyword="piezoelectric",
+        property_keywords=sample_property_keywords,
+        is_sql_db=False,
+        csv_batch_size=10,
+        is_track_pdfs=True,
     )
 
 
@@ -80,58 +94,58 @@ def test_init_custom_track_pdfs_report_path(sample_property_keywords):
     assert processor.track_pdfs_report_path == "/custom/tracking.txt"
 
 
-def test_load_processed_pdfs_from_tracking_file(pdfs_processor):
+def test_load_processed_pdfs_from_tracking_file(pdfs_processor_with_tracking):
     """_load_processed_pdfs reads basename+DOI pairs from the tracking file"""
     tracking_content = "paper1.pdf\t10.1234/a\npaper2.pdf\t10.5678/b\n"
     with (
         patch("os.path.exists", return_value=True),
         patch("builtins.open", mock_open(read_data=tracking_content)),
     ):
-        filenames, dois = pdfs_processor._load_processed_pdfs()
+        filenames, dois = pdfs_processor_with_tracking._load_processed_pdfs()
     assert filenames == {"paper1.pdf", "paper2.pdf"}
     assert dois == {"10.1234/a", "10.5678/b"}
 
 
-def test_load_processed_pdfs_legacy_doi_only_format(pdfs_processor):
+def test_load_processed_pdfs_legacy_doi_only_format(pdfs_processor_with_tracking):
     """_load_processed_pdfs handles legacy tracking files that contain only DOIs"""
     tracking_content = "10.1234/a\n10.5678/b\n"
     with (
         patch("os.path.exists", return_value=True),
         patch("builtins.open", mock_open(read_data=tracking_content)),
     ):
-        filenames, dois = pdfs_processor._load_processed_pdfs()
+        filenames, dois = pdfs_processor_with_tracking._load_processed_pdfs()
     assert filenames == set()
     assert dois == {"10.1234/a", "10.5678/b"}
 
 
-def test_load_processed_pdfs_fallback_to_csv(pdfs_processor):
+def test_load_processed_pdfs_fallback_to_csv(pdfs_processor_with_tracking):
     """_load_processed_pdfs falls back to the CSV when the tracking file is absent"""
     csv_data = pd.DataFrame({"doi": ["10.1234/a", "10.9999/c"]})
     with (
         patch("os.path.exists", side_effect=lambda p: p.endswith(".csv")),
         patch("pandas.read_csv", return_value=csv_data),
     ):
-        filenames, dois = pdfs_processor._load_processed_pdfs()
+        filenames, dois = pdfs_processor_with_tracking._load_processed_pdfs()
     assert filenames == set()
     assert dois == {"10.1234/a", "10.9999/c"}
 
 
-def test_load_processed_pdfs_no_sources(pdfs_processor):
+def test_load_processed_pdfs_no_sources(pdfs_processor_with_tracking):
     """_load_processed_pdfs returns empty sets when neither file exists"""
     with patch("os.path.exists", return_value=False):
-        filenames, dois = pdfs_processor._load_processed_pdfs()
+        filenames, dois = pdfs_processor_with_tracking._load_processed_pdfs()
     assert filenames == set()
     assert dois == set()
 
 
-def test_mark_pdf_processed_writes_to_file(pdfs_processor):
+def test_mark_pdf_processed_writes_to_file(pdfs_processor_with_tracking):
     """_mark_pdf_processed appends basename<TAB>doi to the tracking file"""
     m = mock_open()
     with (
         patch("os.makedirs"),
         patch("builtins.open", m),
     ):
-        pdfs_processor._mark_pdf_processed("/some/path/paper1.pdf", "10.1234/test")
+        pdfs_processor_with_tracking._mark_pdf_processed("/some/path/paper1.pdf", "10.1234/test")
     m().write.assert_called_once_with("paper1.pdf\t10.1234/test\n")
 
 
@@ -303,10 +317,11 @@ def test_process_pdfs_with_doi(mock_metadata, mock_glob, pdfs_processor):
 
 
 @patch("glob.glob")
+@patch("comproscanner.article_processors.pdfs_processor.get_doi_from_crossref", return_value="")
 @patch(
     "comproscanner.article_processors.pdfs_processor.get_paper_metadata_from_openalex"
 )
-def test_process_pdfs_no_doi(mock_metadata, mock_glob, pdfs_processor):
+def test_process_pdfs_no_doi(mock_metadata, mock_crossref, mock_glob, pdfs_processor):
     """Test processing PDFs with no DOI found"""
     mock_glob.return_value = ["/test/path/file1.pdf"]