Merge pull request #110 from t0mmy742/psr12

l0gicgate · web-flow · commit f4be12069a4d · 2020-01-02T21:27:43.000-07:00
PSR-12 + fully-qualified function calls
diff --git a/.travis.yml b/.travis.yml
@@ -1,7 +1,5 @@
 language: php
 
-dist: trusty
-
 matrix:
   include:
   - php: 7.2
@@ -17,10 +15,10 @@ before_script:
 - composer install -n
 
 script:
+- if [[ "$ANALYSIS" != 'true' ]]; then vendor/bin/phpunit ; fi
 - if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/phpunit --coverage-clover clover.xml ; fi
-- vendor/bin/phpunit
-- vendor/bin/phpcs
-- vendor/bin/phpstan analyse src
+- if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/phpcs ; fi
+- if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/phpstan analyse src ; fi
 
 after_success:
 - if [[ "$ANALYSIS" == 'true' ]]; then vendor/bin/php-coveralls --coverage_clover=clover.xml -v ; fi
diff --git a/composer.json b/composer.json
@@ -28,21 +28,22 @@
     }
   ],
   "require": {
+    "php": "^7.2",
+    "ext-SimpleXML": "*",
     "ext-fileinfo": "*",
     "ext-json": "*",
     "ext-libxml": "*",
-    "ext-SimpleXML": "*",
-    "php": "^7.2",
     "psr/http-factory": "^1.0",
     "psr/http-message": "^1.0"
   },
   "require-dev": {
+    "adriansuter/php-autoload-override": "v0.1-beta",
+    "laminas/laminas-diactoros": "^2.0",
     "nyholm/psr7": "^1.0",
+    "php-http/psr7-integration-tests": "dev-master",
     "phpstan/phpstan": "^0.10.3",
     "phpunit/phpunit": "^8.5",
-    "php-http/psr7-integration-tests": "dev-master",
-    "squizlabs/php_codesniffer": "^3.3.2",
-    "laminas/laminas-diactoros": "^2.0"
+    "squizlabs/php_codesniffer": "^3.5"
   },
   "provide": {
     "psr/http-factory": "^1.0"
@@ -66,5 +67,8 @@
     "phpunit": "phpunit",
     "phpcs": "phpcs",
     "phpstan": "phpstan analyse src --memory-limit=-1"
-  }
+  },
+    "config": {
+        "sort-packages": true
+    }
 }
diff --git a/phpcs.xml b/phpcs.xml
@@ -8,10 +8,10 @@
     <arg name="colors"/>
 
     <!-- inherit rules from: -->
-    <rule ref="PSR2"/>
+    <rule ref="PSR12"/>
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
 
     <!-- Paths to check -->
     <file>src</file>
     <file>tests</file>
-</ruleset>
+</ruleset>
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/5.1/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd"
          colors="true"
          bootstrap="tests/bootstrap.php"
 >
diff --git a/src/Factory/DecoratedResponseFactory.php b/src/Factory/DecoratedResponseFactory.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/src/Factory/DecoratedServerRequestFactory.php b/src/Factory/DecoratedServerRequestFactory.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/src/Factory/DecoratedUriFactory.php b/src/Factory/DecoratedUriFactory.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/src/Response.php b/src/Response.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -15,6 +16,24 @@
 use Psr\Http\Message\StreamInterface;
 use RuntimeException;
 
+use function basename;
+use function in_array;
+use function is_array;
+use function is_resource;
+use function is_string;
+use function json_encode;
+use function json_last_error;
+use function json_last_error_msg;
+use function mime_content_type;
+use function preg_replace;
+use function rawurlencode;
+use function sprintf;
+use function stream_get_meta_data;
+use function strlen;
+use function substr;
+
+use const JSON_ERROR_NONE;
+
 class Response implements ResponseInterface
 {
     /**
@@ -32,7 +51,7 @@ class Response implements ResponseInterface
      *
      * @var string
      */
-    const EOL = "\r\n";
+    public const EOL = "\r\n";
 
     /**
      * @param ResponseInterface $response
diff --git a/src/ServerRequest.php b/src/ServerRequest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -15,6 +16,22 @@
 use Psr\Http\Message\UriInterface;
 use RuntimeException;
 
+use function array_merge;
+use function count;
+use function explode;
+use function is_array;
+use function is_null;
+use function is_object;
+use function json_decode;
+use function libxml_clear_errors;
+use function libxml_disable_entity_loader;
+use function libxml_use_internal_errors;
+use function parse_str;
+use function preg_split;
+use function property_exists;
+use function simplexml_load_string;
+use function strtolower;
+
 class ServerRequest implements ServerRequestInterface
 {
     /**
diff --git a/src/Uri.php b/src/Uri.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Assets/PhpFunctionOverrides.php b/tests/Assets/PhpFunctionOverrides.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Providers/LaminasDiactorosPsr17FactoryProvider.php b/tests/Providers/LaminasDiactorosPsr17FactoryProvider.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Providers/NyholmPsr17FactoryProvider.php b/tests/Providers/NyholmPsr17FactoryProvider.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Providers/Psr17FactoryProvider.php b/tests/Providers/Psr17FactoryProvider.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Providers/ZendDiactorosPsr17FactoryProvider.php b/tests/Providers/ZendDiactorosPsr17FactoryProvider.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
diff --git a/tests/Psr7Integration/Laminas/ResponseTest.php b/tests/Psr7Integration/Laminas/ResponseTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedResponseFactory;
 use Slim\Tests\Http\Providers\LaminasDiactorosPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class ResponseTest extends ResponseIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Laminas/ServerRequestTest.php b/tests/Psr7Integration/Laminas/ServerRequestTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedServerRequestFactory;
 use Slim\Tests\Http\Providers\LaminasDiactorosPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class ServerRequestTest extends ServerRequestIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Laminas/UriTest.php b/tests/Psr7Integration/Laminas/UriTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedUriFactory;
 use Slim\Tests\Http\Providers\LaminasDiactorosPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class UriTest extends UriIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Nyholm/ResponseTest.php b/tests/Psr7Integration/Nyholm/ResponseTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedResponseFactory;
 use Slim\Tests\Http\Providers\NyholmPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class ResponseTest extends ResponseIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Nyholm/ServerRequestTest.php b/tests/Psr7Integration/Nyholm/ServerRequestTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedServerRequestFactory;
 use Slim\Tests\Http\Providers\NyholmPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class ServerRequestTest extends ServerRequestIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Nyholm/UriTest.php b/tests/Psr7Integration/Nyholm/UriTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Http\Factory\DecoratedUriFactory;
 use Slim\Tests\Http\Providers\NyholmPsr17FactoryProvider;
 
+use function define;
+use function defined;
+
 class UriTest extends UriIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Zend/ResponseTest.php b/tests/Psr7Integration/Zend/ResponseTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Tests\Http\Providers\ZendDiactorosPsr17FactoryProvider;
 use Zend\Diactoros\StreamFactory;
 
+use function define;
+use function defined;
+
 class ResponseTest extends ResponseIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Zend/ServerRequestTest.php b/tests/Psr7Integration/Zend/ServerRequestTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Tests\Http\Providers\ZendDiactorosPsr17FactoryProvider;
 use Zend\Diactoros\StreamFactory;
 
+use function define;
+use function defined;
+
 class ServerRequestTest extends ServerRequestIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/Psr7Integration/Zend/UriTest.php b/tests/Psr7Integration/Zend/UriTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -14,6 +15,9 @@
 use Slim\Tests\Http\Providers\ZendDiactorosPsr17FactoryProvider;
 use Zend\Diactoros\StreamFactory;
 
+use function define;
+use function defined;
+
 class UriTest extends UriIntegrationTest
 {
     public static function setUpBeforeClass(): void
diff --git a/tests/ResponseTest.php b/tests/ResponseTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Slim Framework (https://slimframework.com)
  *
@@ -15,6 +16,15 @@
 use Slim\Http\Response;
 use Slim\Tests\Http\Providers\Psr17FactoryProvider;
 
+use function chr;
+use function fclose;
+use function fopen;
+use function is_resource;
+use function json_decode;
+use function property_exists;
+
+use const JSON_HEX_AMP;
+
 class ResponseTest extends TestCase
 {
     public function testDisableSetter()
@@ -639,8 +649,8 @@ public function testWithInvalidJsonThrowsException()
     {
         $this->expectException(RuntimeException::class);
 
-        $data = ['foo' => 'bar'.chr(233)];
-        $this->assertEquals('bar'.chr(233), $data['foo']);
+        $data = ['foo' => 'bar' . chr(233)];
+        $this->assertEquals('bar' . chr(233), $data['foo']);
 
         foreach ($this->factoryProviders as $factoryProvider) {
             /** @var Psr17FactoryProvider $provider */
diff --git a/tests/ServerRequestTest.php b/tests/ServerRequestTest.php
diff --git a/tests/TestCase.php b/tests/TestCase.php
diff --git a/tests/UriTest.php b/tests/UriTest.php
diff --git a/tests/bootstrap.php b/tests/bootstrap.php

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`<?xml version="1.0" encoding="UTF-8"?>`
`2`	`2`	`<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"`
`3`		`- xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/5.1/phpunit.xsd"`
	`3`	`+ xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd"`
`4`	`4`	`colors="true"`
`5`	`5`	`bootstrap="tests/bootstrap.php"`
`6`	`6`	`>`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+`
`2`	`3`	`/**`
`3`	`4`	`* Slim Framework (https://slimframework.com)`
`4`	`5`	`*`