Stop auto-migrating legacy quota; add --sync flag

Don't auto-migrate or create experimental.quotaToast on config load anymore. The loader now prefers the plugin sidecar (opencode-quota/quota-toast.json) and only falls back to experimental.quotaToast when the sidecar is absent; normal runtime does not write or migrate legacy blocks. Added an explicit init option and CLI flag (--sync-legacy-config) and installer support (syncLegacyConfig) to write/sync the legacy experimental.quotaToast when requested. Refactored config loading (removed migration/pending-migration code paths), improved invalid-plugin JSON error reporting, and updated tests and README to reflect the new behavior. Also added small type/comment and utility changes used by the installer sync logic.

Author: slkiser

README.md

@@ -28,7 +28,7 @@ npx @slkiser/opencode-quota init
 > [!IMPORTANT]
 > OpenCode `>= 1.4.3` and Node.js `>= 18` are required.
 
-The installer is append-only and preserves existing config values. It asks where to install, which quota UI to enable, whether providers should be auto-detected, which quota display style to use, how percentages should be labeled, and whether session input/output tokens should appear in quota displays.
+The installer is append-only and preserves existing config values. It asks where to install, which quota UI to enable, whether providers should be auto-detected, which quota display style to use, how percentages should be labeled, and whether session input/output tokens should appear in quota displays. By default it writes quota settings to `opencode-quota/quota-toast.json` only; if you also need the legacy OpenCode `experimental.quotaToast` block, run `npx @slkiser/opencode-quota init --sync-legacy-config`.
 
 After install:
 
@@ -67,7 +67,7 @@ If you also want the sidebar, add the same package to the `tui.json` or `tui.jso
 }
 ```
 
-Quota settings live in `opencode-quota/quota-toast.json` next to the OpenCode config file chosen by the installer (project or global). Existing `experimental.quotaToast` settings in `opencode.json` / `opencode.jsonc` still work and are copied into the plugin-owned file when possible; if both exist, `opencode-quota/quota-toast.json` wins. Quota settings do not live in `tui.json`.
+Quota settings live in `opencode-quota/quota-toast.json` next to the OpenCode config file chosen by the installer (project or global). On load, OpenCode Quota reads that sidecar first and falls back to existing `experimental.quotaToast` settings in `opencode.json` / `opencode.jsonc` only when the sidecar is absent. Normal runtime/load does not create, re-add, or migrate `experimental.quotaToast`; use `init --sync-legacy-config` when you explicitly want the installer to also write/sync that legacy block. Quota settings do not live in `tui.json`.
 
 ### What plugin adds
 

src/bin/opencode-quota.ts

@@ -8,12 +8,13 @@ import { runInitInstaller } from "../lib/init-installer.js";
 
 const USAGE = [
   "Usage:",
-  "  npx @slkiser/opencode-quota init",
+  "  npx @slkiser/opencode-quota init [--sync-legacy-config]",
   "  npx @slkiser/opencode-quota show [--provider <provider-id>]",
   "  npx @slkiser/opencode-quota --help",
   "",
   "Commands:",
   "  init    Run the interactive quota installer",
+  "          --sync-legacy-config also writes experimental.quotaToast",
   "  show    Print a quick quota glance",
 ].join("\n");
 
@@ -54,8 +55,13 @@ export async function main(argv = process.argv.slice(2)): Promise<number> {
     return 0;
   }
 
-  if (command === "init" && rest.length === 0) {
-    return await runInitInstaller();
+  if (command === "init") {
+    if (rest.length === 0) {
+      return await runInitInstaller();
+    }
+    if (rest.length === 1 && rest[0] === "--sync-legacy-config") {
+      return await runInitInstaller({ syncLegacyConfig: true });
+    }
   }
 
   if (command === "show") {

src/lib/config.ts

@@ -23,7 +23,6 @@ import { existsSync } from "fs";
 import { readFile } from "fs/promises";
 import { join } from "path";
 
-import { writeJsonAtomic } from "./atomic-json.js";
 import { getOpencodeRuntimeDirCandidates } from "./opencode-runtime-paths.js";
 
 export const QUOTA_TOAST_CONFIG_RELATIVE_PATH = "opencode-quota/quota-toast.json";
@@ -147,16 +146,6 @@ interface ConfigLayerCandidate {
   pluginPath: string;
 }
 
-interface PendingLegacyMigration {
-  quotaToastConfig: Record<string, unknown>;
-  sourcePath: string;
-  sourcePaths: Set<string>;
-  scope: ConfigLayerScope;
-  config: QuotaToastConfig;
-  settingSources: QuotaToastSettingSources;
-  configIssues: LoadConfigIssue[];
-}
-
 export function getQuotaToastConfigPath(configRootDir: string): string {
   return join(configRootDir, QUOTA_TOAST_CONFIG_RELATIVE_PATH);
 }
@@ -705,18 +694,18 @@ function buildConfigLayerCandidatesForRoot(
 ): ConfigLayerCandidate[] {
   const pluginPath = getQuotaToastConfigPath(dir);
   return [
-    ...CONFIG_FILENAMES.map((filename) => ({
-      path: join(dir, filename),
-      scope,
-      kind: "legacy" as const,
-      pluginPath,
-    })),
     {
       path: pluginPath,
       scope,
       kind: "plugin" as const,
       pluginPath,
     },
+    ...CONFIG_FILENAMES.map((filename) => ({
+      path: join(dir, filename),
+      scope,
+      kind: "legacy" as const,
+      pluginPath,
+    })),
   ];
 }
 
@@ -742,85 +731,6 @@ function getConfigLayerSourceLabel(candidate: ConfigLayerCandidate): string {
   return `${candidate.path} (${suffix})`;
 }
 
-async function migrateLegacyQuotaToastConfig(params: {
-  pluginPath: string;
-  quotaToastConfig: Record<string, unknown>;
-}): Promise<boolean> {
-  if (existsSync(params.pluginPath)) {
-    return true;
-  }
-
-  try {
-    await writeJsonAtomic(params.pluginPath, params.quotaToastConfig, { trailingNewline: true });
-    return true;
-  } catch {
-    // Best effort only. The legacy config remains readable for backward compatibility.
-    return false;
-  }
-}
-
-function buildQuotaToastMigrationPayload(
-  config: QuotaToastConfig,
-  settingSources: QuotaToastSettingSources,
-  includeSource: (source: string) => boolean,
-): Record<string, unknown> {
-  const payload: Record<string, unknown> = {};
-  const hasSource = (key: QuotaToastSettingSourceKey): boolean => {
-    const source = settingSources[key];
-    return typeof source === "string" && includeSource(source);
-  };
-
-  if (hasSource("enabled")) payload.enabled = config.enabled;
-  if (hasSource("enableToast")) payload.enableToast = config.enableToast;
-  if (hasSource("formatStyle")) payload.formatStyle = config.formatStyle;
-  if (hasSource("percentDisplayMode")) payload.percentDisplayMode = config.percentDisplayMode;
-  if (hasSource("minIntervalMs")) payload.minIntervalMs = config.minIntervalMs;
-  if (hasSource("debug")) payload.debug = config.debug;
-  if (hasSource("enabledProviders")) {
-    payload.enabledProviders =
-      config.enabledProviders === "auto" ? "auto" : [...config.enabledProviders];
-  }
-  if (hasSource("anthropicBinaryPath")) payload.anthropicBinaryPath = config.anthropicBinaryPath;
-  if (hasSource("googleModels")) payload.googleModels = [...config.googleModels];
-  if (hasSource("alibabaCodingPlanTier")) {
-    payload.alibabaCodingPlanTier = config.alibabaCodingPlanTier;
-  }
-  if (hasSource("cursorPlan")) payload.cursorPlan = config.cursorPlan;
-  if (hasSource("cursorIncludedApiUsd")) {
-    payload.cursorIncludedApiUsd = config.cursorIncludedApiUsd;
-  }
-  if (hasSource("cursorBillingCycleStartDay")) {
-    payload.cursorBillingCycleStartDay = config.cursorBillingCycleStartDay;
-  }
-  if (hasSource("opencodeGoWindows")) payload.opencodeGoWindows = [...config.opencodeGoWindows];
-  if (hasSource("pricingSnapshot.source") || hasSource("pricingSnapshot.autoRefresh")) {
-    const pricingSnapshot: Record<string, unknown> = {};
-    if (hasSource("pricingSnapshot.source")) {
-      pricingSnapshot.source = config.pricingSnapshot.source;
-    }
-    if (hasSource("pricingSnapshot.autoRefresh")) {
-      pricingSnapshot.autoRefresh = config.pricingSnapshot.autoRefresh;
-    }
-    payload.pricingSnapshot = pricingSnapshot;
-  }
-  if (hasSource("showOnIdle")) payload.showOnIdle = config.showOnIdle;
-  if (hasSource("showOnQuestion")) payload.showOnQuestion = config.showOnQuestion;
-  if (hasSource("showOnCompact")) payload.showOnCompact = config.showOnCompact;
-  if (hasSource("showOnBothFail")) payload.showOnBothFail = config.showOnBothFail;
-  if (hasSource("toastDurationMs")) payload.toastDurationMs = config.toastDurationMs;
-  if (hasSource("onlyCurrentModel")) payload.onlyCurrentModel = config.onlyCurrentModel;
-  if (hasSource("showSessionTokens")) payload.showSessionTokens = config.showSessionTokens;
-  if (hasSource("layout.maxWidth") || hasSource("layout.narrowAt") || hasSource("layout.tinyAt")) {
-    const layout: Record<string, unknown> = {};
-    if (hasSource("layout.maxWidth")) layout.maxWidth = config.layout.maxWidth;
-    if (hasSource("layout.narrowAt")) layout.narrowAt = config.layout.narrowAt;
-    if (hasSource("layout.tinyAt")) layout.tinyAt = config.layout.tinyAt;
-    payload.layout = layout;
-  }
-
-  return payload;
-}
-
 /**
  * Load plugin configuration from OpenCode config
  *
@@ -866,95 +776,56 @@ export async function loadConfig(
     const workspaceConfigPaths: string[] = [];
     const settingSources: QuotaToastSettingSources = {};
     const configIssues: LoadConfigIssue[] = [];
-    const pendingLegacyMigrations = new Map<string, PendingLegacyMigration>();
 
     for (const candidate of buildConfigLayerCandidates(configDirs, configRootDir)) {
-      const pendingMigration =
-        candidate.kind === "plugin" ? pendingLegacyMigrations.get(candidate.path) : undefined;
-
-      if (candidate.kind === "plugin") {
-        if (pendingMigration && !existsSync(candidate.path)) {
-          await migrateLegacyQuotaToastConfig({
-            pluginPath: candidate.path,
-            quotaToastConfig: pendingMigration.quotaToastConfig,
-          });
-        }
-      } else if (existsSync(candidate.pluginPath)) {
+      if (candidate.kind === "legacy" && existsSync(candidate.pluginPath)) {
         continue;
       }
 
-      let rawQuotaToast: Record<string, unknown> | undefined;
-      let sourcePath = getConfigLayerSourceLabel(candidate);
-      let scope = candidate.scope;
-
-      if (existsSync(candidate.path)) {
-        const parsed = await readJson(candidate.path);
-        if (!isPlainObject(parsed)) {
-          continue;
-        }
-
-        const extractedQuotaToast =
-          candidate.kind === "plugin"
-            ? parsed
-            : isPlainObject(parsed.experimental)
-              ? parsed.experimental.quotaToast
-              : undefined;
-        if (!isPlainObject(extractedQuotaToast)) {
-          continue;
-        }
-        rawQuotaToast = extractedQuotaToast;
-      } else if (candidate.kind === "plugin" && pendingMigration) {
-        rawQuotaToast = pendingMigration.quotaToastConfig;
-        sourcePath = pendingMigration.sourcePath;
-        scope = pendingMigration.scope;
-      } else {
+      if (!existsSync(candidate.path)) {
         continue;
       }
 
-      if (candidate.kind === "legacy") {
-        const pending = pendingLegacyMigrations.get(candidate.pluginPath) ?? {
-          quotaToastConfig: {},
-          sourcePath,
-          sourcePaths: new Set<string>(),
-          scope,
-          config: cloneConfig(config),
-          settingSources: { ...settingSources },
-          configIssues: [],
-        };
-        pending.sourcePaths.add(sourcePath);
-        applyValidatedQuotaToastPatch(
-          pending.config,
-          extractValidatedQuotaToastPatch(rawQuotaToast, (key, message) => {
-            pending.configIssues.push({ path: sourcePath, key, message });
-          }),
-          sourcePath,
-          pending.settingSources,
-        );
-        pending.quotaToastConfig = buildQuotaToastMigrationPayload(
-          pending.config,
-          pending.settingSources,
-          (source) => pending.sourcePaths.has(source),
-        );
-        pending.sourcePath = sourcePath;
-        pending.scope = scope;
-        pendingLegacyMigrations.set(candidate.pluginPath, pending);
+      const parsed = await readJson(candidate.path);
+      if (!isPlainObject(parsed)) {
+        if (candidate.kind === "plugin") {
+          const sourcePath = getConfigLayerSourceLabel(candidate);
+          usedPaths.push(sourcePath);
+          if (candidate.scope === "global") {
+            globalConfigPaths.push(sourcePath);
+          } else {
+            workspaceConfigPaths.push(sourcePath);
+          }
+          configIssues.push({
+            path: sourcePath,
+            key: "$root",
+            message: "expected readable JSON object",
+          });
+        }
         continue;
       }
 
-      if (candidate.kind === "plugin" && pendingMigration?.configIssues.length) {
-        configIssues.push(...pendingMigration.configIssues);
+      const extractedQuotaToast =
+        candidate.kind === "plugin"
+          ? parsed
+          : isPlainObject(parsed.experimental)
+            ? parsed.experimental.quotaToast
+            : undefined;
+      if (!isPlainObject(extractedQuotaToast)) {
+        continue;
       }
 
+      const sourcePath = getConfigLayerSourceLabel(candidate);
       usedPaths.push(sourcePath);
-      if (scope === "global") {
+      if (candidate.scope === "global") {
         globalConfigPaths.push(sourcePath);
       } else {
         workspaceConfigPaths.push(sourcePath);
       }
 
       applyValidatedQuotaToastPatch(
         config,
-        extractValidatedQuotaToastPatch(rawQuotaToast, (key, message) => {
+        extractValidatedQuotaToastPatch(extractedQuotaToast, (key, message) => {
           configIssues.push({ path: sourcePath, key, message });
         }),
         sourcePath,