Remove amgb_assert_uniform (MPI sync points); bump to 0.11.39

Author: Sébastien Loisel

Project.toml

@@ -1,7 +1,7 @@
 name = "MultiGridBarrier"
 uuid = "9e2c1f1d-9131-4ad4-b32f-bd2a0b0ecd1e"
 authors = ["Sébastien Loisel"]
-version = "0.11.38"
+version = "0.11.39"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

src/AlgebraicMultiGridBarrier.jl

@@ -1,4 +1,4 @@
-export amgb, Geometry, Convex, convex_linear, convex_Euclidian_power, AMGBConvergenceFailure, apply_D, linesearch_illinois, linesearch_backtracking, stopping_exact, stopping_inexact, interpolate, intersect, plot, Log, default_idx, multigrid_from_fine_grid, map_rows, map_rows_gpu, amgb_assert_uniform
+export amgb, Geometry, Convex, convex_linear, convex_Euclidian_power, AMGBConvergenceFailure, apply_D, linesearch_illinois, linesearch_backtracking, stopping_exact, stopping_inexact, interpolate, intersect, plot, Log, default_idx, multigrid_from_fine_grid, map_rows, map_rows_gpu
 
 @doc raw"""
     Log(x::T) where {T} = x<=0 ? T(-Inf) : Base.log(x)     # "Convex programmer's log"
@@ -79,10 +79,6 @@ amgb_zeros(::LinearAlgebra.Adjoint{T, Matrix{T}},m,n) where {T} = zeros(T,m,n)
 amgb_zeros(::Type{Vector{T}}, m) where {T} = zeros(T, m)
 amgb_all_isfinite(z::Vector{T}) where {T} = all(isfinite.(z))
 
-# Assert that a value is uniform across all MPI ranks (no-op for non-MPI)
-# Override in MultiGridBarrierMPI to actually check uniformity
-amgb_assert_uniform(x, msg="") = nothing
-
 amgb_diag(::SparseMatrixCSC{T,Int}, z::Vector{T},m=length(z),n=length(z)) where {T} = spdiagm(m,n,0=>z)
 amgb_diag(::Matrix{T}, z::Vector{T},m=length(z),n=length(z)) where {T} = diagm(m,n,0=>z)
 
@@ -1527,7 +1523,6 @@ function barrier(Q::Convex{T})::Barrier where T
         y = map_rows_gpu(F0, args..., Dz)
         # GPU-compatible: avoid inline closure by splitting computation
         result = dot(w, y) + sum(w .* map_rows_gpu(dot, c, Dz))
-        amgb_assert_uniform(result, "f0: barrier function result")
         result
     end
 
@@ -1690,7 +1685,6 @@ function amgb_step(Q::Vector{<:Convex{T}},
             line_search=ls,
             printlog)
         its[J] += SOL.k
-        amgb_assert_uniform(SOL.converged, "eta: SOL.converged at j=$j J=$J")
         if SOL.converged
             z = z + R*SOL.x
         end
@@ -1964,19 +1958,15 @@ function newton(::Type{Mat}, ::Type{T},
         n = solve(symmetric(H), g)
         @assert amgb_all_isfinite(n)
         inc = dot(g,n)
-        amgb_assert_uniform(inc, "newton: inc after dot(g,n)")
         @debug("k=",k," y=",y," ‖g‖=",norm(g), " λ^2=",inc)
         if inc<=0
             converged = true
-            amgb_assert_uniform(converged, "newton: converged after inc<=0")
             break
         end
         (xnext,ynext,gnext) = line_search(x,y,g,n,F0,F1;printlog)
-        amgb_assert_uniform(ynext, "newton: ynext after line_search")
         if stopping_criterion(ymin,ynext,gmin,gnext,n,sqrt(incmin),sqrt(inc)) #ynext>=ymin && norm(gnext)>=theta*norm(g)
             @debug("converged: ymin=",ymin," ynext=",ynext," ‖gnext‖=",norm(gnext)," λ=",sqrt(inc)," λmin=",sqrt(incmin))
             converged = true
-            amgb_assert_uniform(converged, "newton: converged after stopping_criterion")
         end
         x,y,g = xnext,ynext,gnext
         gmin = min(gmin,norm(g))