Clean up CI and fix MPI desync issues

- Remove tmate debug session
- Restore Julia 1.10 and use Pkg.add(url=...) for dependencies
- Remove [sources] section from Project.toml (requires Julia 1.11)
- Enable julia-actions/cache
- Remove logfile=io0() from test_parabolic.jl (caused desync with QuietTestSet)
- Remove amgb_assert_uniform MPI implementation (no longer used)

Author: Sébastien Loisel

.github/workflows/CI.yml

@@ -37,18 +37,10 @@ jobs:
 
       - uses: julia-actions/setup-julia@v2
         with:
-          version: '1.11'
+          version: '1.10'
           arch: x64
 
-      # Skip cache - we need fresh builds from git main branches
-      # - uses: julia-actions/cache@v2
-
-      - name: Clear stale compiled packages and clones
-        run: |
-          rm -rf ~/.julia/compiled
-          rm -rf ~/.julia/packages/LinearAlgebraMPI
-          rm -rf ~/.julia/packages/MultiGridBarrier
-          rm -rf ~/.julia/clones
+      - uses: julia-actions/cache@v2
 
       - name: Build package with system Python
         env:
@@ -57,19 +49,15 @@ jobs:
           julia --project=. -e '
             using Pkg
             Pkg.add(name="OpenSSL_jll", version="3.0")
+            Pkg.add(url="https://github.com/sloisel/LinearAlgebraMPI.jl.git", rev="main")
+            Pkg.add(url="https://github.com/sloisel/MultiGridBarrier.jl.git", rev="main")
             Pkg.instantiate()
             Pkg.build("PyCall")
           '
 
       - name: Precompile package
         uses: julia-actions/julia-buildpkg@v1
 
-      - name: Setup tmate debug session
-        uses: mxschmitt/action-tmate@v3
-        with:
-          limit-access-to-actor: true
-        timeout-minutes: 30
-
       - name: Run tests with coverage
         uses: julia-actions/julia-runtest@v1
         with:
@@ -110,17 +98,9 @@ jobs:
 
       - uses: julia-actions/setup-julia@v2
         with:
-          version: '1.11'
-
-      # Skip cache - we need fresh builds from git main branches
-      # - uses: julia-actions/cache@v2
+          version: '1.10'
 
-      - name: Clear stale compiled packages and clones
-        run: |
-          rm -rf ~/.julia/compiled
-          rm -rf ~/.julia/packages/LinearAlgebraMPI
-          rm -rf ~/.julia/packages/MultiGridBarrier
-          rm -rf ~/.julia/clones
+      - uses: julia-actions/cache@v2
 
       - name: Configure doc environment
         env:
@@ -130,6 +110,8 @@ jobs:
             using Pkg
             Pkg.develop(PackageSpec(path=pwd()))
             Pkg.add(name="OpenSSL_jll", version="3.0")
+            Pkg.add(url="https://github.com/sloisel/LinearAlgebraMPI.jl.git", rev="main")
+            Pkg.add(url="https://github.com/sloisel/MultiGridBarrier.jl.git", rev="main")
             Pkg.instantiate()
             Pkg.build("PyCall")
           '

Project.toml

@@ -13,17 +13,13 @@ PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
-[sources]
-LinearAlgebraMPI = {url = "https://github.com/sloisel/LinearAlgebraMPI.jl.git", rev = "main"}
-MultiGridBarrier = {url = "https://github.com/sloisel/MultiGridBarrier.jl.git", rev = "main"}
-
 [compat]
 BenchmarkTools = "1.6"
 LinearAlgebraMPI = "0.1"
 MPI = "0.20"
 MultiGridBarrier = "0.11"
 PrecompileTools = "1"
-julia = "1.11"
+julia = "1.10"
 
 [extras]
 BenchmarkTools = "6e4b80f9-dd63-53aa-95a3-0cdb28fa8baf"

src/MultiGridBarrierMPI.jl

@@ -58,7 +58,7 @@ using PrecompileTools
 # ============================================================================
 
 # Import the functions we need to extend
-import MultiGridBarrier: amgb_zeros, amgb_all_isfinite, amgb_assert_uniform, amgb_diag, amgb_blockdiag, map_rows, map_rows_gpu, vertex_indices, _raw_array, _to_cpu_array, _rows_to_svectors
+import MultiGridBarrier: amgb_zeros, amgb_all_isfinite, amgb_diag, amgb_blockdiag, map_rows, map_rows_gpu, vertex_indices, _raw_array, _to_cpu_array, _rows_to_svectors
 
 # amgb_zeros: Create distributed zero matrices/vectors using Base.zeros from LinearAlgebraMPI
 MultiGridBarrier.amgb_zeros(::SparseMatrixMPI{T,Ti,AV}, m, n) where {T,Ti,AV} =
@@ -87,112 +87,6 @@ function MultiGridBarrier.amgb_all_isfinite(z::VectorMPI{T,AV}) where {T,AV}
     MPI.Allreduce(local_all_finite, &, MPI.COMM_WORLD)
 end
 
-# amgb_assert_uniform: Assert that a scalar value is identical on all MPI ranks
-# Gathers all values to rank 0, checks uniformity, and aborts if not uniform
-function MultiGridBarrier.amgb_assert_uniform(x::T, msg::String="") where T<:Number
-    comm = MPI.COMM_WORLD
-    rank = MPI.Comm_rank(comm)
-    nranks = MPI.Comm_size(comm)
-
-    # Gather all values to rank 0
-    all_values = MPI.Gather(x, 0, comm)
-
-    # Check uniformity on rank 0
-    is_uniform = true
-    if rank == 0
-        ref_val = all_values[1]
-        for i in 2:nranks
-            # Use isequal for exact equality (handles NaN correctly: isequal(NaN,NaN)=true)
-            if !isequal(all_values[i], ref_val)
-                is_uniform = false
-                break
-            end
-        end
-    end
-
-    # Broadcast uniformity result to all ranks
-    is_uniform = MPI.Bcast(is_uniform, 0, comm)
-
-    if !is_uniform
-        # Print error info on rank 0 only (use stdout for visibility)
-        if rank == 0
-            println("\n" * "="^60)
-            println("MPI UNIFORMITY ASSERTION FAILED: $msg")
-            println("="^60)
-            println("Values across ranks:")
-            for i in 1:nranks
-                println("  Rank $(i-1): $(all_values[i])")
-            end
-            println("\nStack trace:")
-            for frame in stacktrace()
-                println("  ", frame)
-            end
-            println("="^60)
-            flush(stdout)
-        end
-
-        # Small delay to ensure output is flushed before abort
-        sleep(0.1)
-
-        # Abort all ranks
-        MPI.Abort(comm, 1)
-    end
-
-    return nothing
-end
-
-# Also handle boolean specifically for converged flags
-function MultiGridBarrier.amgb_assert_uniform(x::Bool, msg::String="")
-    comm = MPI.COMM_WORLD
-    rank = MPI.Comm_rank(comm)
-    nranks = MPI.Comm_size(comm)
-
-    # Convert to Int for MPI (some MPI implementations don't handle Bool well)
-    x_int = Int32(x)
-    all_values = MPI.Gather(x_int, 0, comm)
-
-    # Check uniformity on rank 0
-    is_uniform = true
-    if rank == 0
-        ref_val = all_values[1]
-        for i in 2:nranks
-            if all_values[i] != ref_val
-                is_uniform = false
-                break
-            end
-        end
-    end
-
-    # Broadcast uniformity result to all ranks
-    is_uniform = MPI.Bcast(is_uniform, 0, comm)
-
-    if !is_uniform
-        # Print error info on rank 0 only (use stdout for visibility)
-        if rank == 0
-            println("\n" * "="^60)
-            println("MPI UNIFORMITY ASSERTION FAILED: $msg")
-            println("="^60)
-            println("Boolean values across ranks:")
-            for i in 1:nranks
-                println("  Rank $(i-1): $(Bool(all_values[i]))")
-            end
-            println("\nStack trace:")
-            for frame in stacktrace()
-                println("  ", frame)
-            end
-            println("="^60)
-            flush(stdout)
-        end
-
-        # Small delay to ensure output is flushed before abort
-        sleep(0.1)
-
-        MPI.Abort(comm, 1)
-    end
-
-    return nothing
-end
-
 # amgb_diag: Create diagonal matrix from vector
 # SparseMatrixMPI with VectorMPI - preserves vector's array type in nzval
 MultiGridBarrier.amgb_diag(::SparseMatrixMPI{T,Ti,AV}, z::VectorMPI{T,AV2}, m=length(z), n=length(z)) where {T,Ti,AV,AV2} =