testDialectAndServerVersionShareSingleSelectVersionQuery を 2 順序網羅に拡張

レビュー指摘 (nits): 既存テストのコメントが「regardless of order」と謳いながら
serverVersion → dialect の 1 順序しか検証していなかった。将来 dialect() が
serverVersion() 経由をやめた場合に dialect 先行順序の不変条件が抜ける
リファクタ耐性問題を解消する。

DataProvider で 2 順序 (serverVersion 先行 / dialect 先行) を網羅し、
どちらの順序でも SELECT VERSION() が 1 回のみ実行されることを保証。

Author: logicraft

tests/Unit/Database/ConnectionTest.php

@@ -8,6 +8,7 @@
 use PDO;
 use Pdo\Sqlite;
 use PDOStatement;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use RuntimeException;
 use Sloop\Database\Connection;
@@ -527,7 +528,22 @@ public function testServerVersionCachesResultAcrossCalls(): void
         $this->assertSame($first, $second);
     }
 
-    public function testDialectAndServerVersionShareSingleSelectVersionQuery(): void
+    /**
+     * @return array<string, array{0: list<string>}>
+     */
+    public static function interleavedDialectAndServerVersionCallProvider(): array
+    {
+        return [
+            'serverVersion first' => [['serverVersion', 'dialect', 'serverVersion', 'dialect']],
+            'dialect first'       => [['dialect', 'serverVersion', 'dialect', 'serverVersion']],
+        ];
+    }
+
+    /**
+     * @param list<string> $callOrder
+     */
+    #[DataProvider('interleavedDialectAndServerVersionCallProvider')]
+    public function testDialectAndServerVersionShareSingleSelectVersionQuery(array $callOrder): void
     {
         // Both getters are independently lazy via ??= but must share a single
         // `SELECT VERSION()` execution regardless of which is called first or
@@ -543,10 +559,13 @@ public function testDialectAndServerVersionShareSingleSelectVersionQuery(): void
 
         $connection = new Connection($pdo, 'test');
 
-        $connection->serverVersion();
-        $connection->dialect();
-        $connection->serverVersion();
-        $connection->dialect();
+        foreach ($callOrder as $method) {
+            if ($method === 'dialect') {
+                $connection->dialect();
+            } else {
+                $connection->serverVersion();
+            }
+        }
 
         $this->assertSame(Dialect::MariaDB, $connection->dialect());
         $this->assertSame('10.11.11-MariaDB', $connection->serverVersion());