Make naming of stack locations configurable#386
Merged
Conversation
mkannwischer
requested changes
Jan 8, 2026
Collaborator
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. Overall this functions well.
A couple of comments below.
willieyz
force-pushed
the
stack-spill
branch
3 times, most recently
from
43cd8f4 to
397bcf8
Compare
This commit introduces configurable stack naming conventions to support different contexts when using spill optimization. This enables SLOTHY to generate assembly with custom stack location naming conventions when using `-c constraints.allow_spills=True`, allowing integration with projects that have specific naming requirements (e.g., "MLK_STACK_LOC_", "CUSTOM_STACK_", etc.). Example usage: slothy-cli -c constraints.allow_spills=True -c constraints.spill_stack_loc_prefix=MLK_STACK_LOC input.s Signed-off-by: willieyz <willie.zhao@chelpis.com>
mkannwischer
approved these changes
Jan 12, 2026
Collaborator
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespace STACK_SIZE pq-code-package/mlkem-native#1396,
and the optimization ran successfully using the MLK_STACK_LOC_ prefix.