Add X25519 example in python and CI#427
Open
dop-amin wants to merge 1 commit into
Open
Conversation
dop-amin
changed the title
* Includes "full" optimization (performance verified against pre-existing code in opt directory after running python example on M4 Mac) * Includes simplified test-case for CI that exhibits some of the important features of the x25519 optimization but with vastly relaxed options.
mkannwischer
force-pushed
the
missing-check
branch
from
d290dfd to
b4d5bba
Compare
mkannwischer
approved these changes
Apr 13, 2026
Collaborator
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
LGTM. Did you benchmark this on an A53/A55 to check if this achieves the same performance as in the paper?
Collaborator
Author
|
The benchmarks don't fully match the original performance. As there appears to be some variance in the optimization (+500 cycles from Run 1 -> Run 2), the question is whether the difference to the original is due to that or due to some change in the model/SLOTHY. I will try running the optimization a few more times, I recall we took the best result over multiple runs back then as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to improve upon the CI coverage and completeness fo examples of the assembly present in the repo.
Currently done: