Skip to content

chore: verify SLSA token at creation#4151

Merged
ramonpetgrave64 merged 1 commit into
slsa-framework:mainfrom
ianlewis:1668-fix-todo
Jun 24, 2025
Merged

chore: verify SLSA token at creation#4151
ramonpetgrave64 merged 1 commit into
slsa-framework:mainfrom
ianlewis:1668-fix-todo

Conversation

@ianlewis

@ianlewis ianlewis commented Mar 19, 2025

Copy link
Copy Markdown
Member

Summary

Verify the SLSA token at creation time as a sanity check.

Fixes #1668

Testing Process

SLSA token creation (slsa-setup) and verification (verify-token) tested on the following run (though the build itself failed).
https://github.com/ianlewis/actions-test/actions/runs/13939731816

Should be caught on e2e tests as well.

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

@ianlewis ianlewis requested a review from a team as a code owner March 19, 2025 05:04
@ianlewis ianlewis requested a review from a team March 19, 2025 05:05
@ianlewis ianlewis marked this pull request as draft March 19, 2025 05:06
@ianlewis ianlewis force-pushed the 1668-fix-todo branch 4 times, most recently from 2d41628 to efee55f Compare March 19, 2025 05:43
@ianlewis ianlewis marked this pull request as ready for review March 19, 2025 05:47
Signed-off-by: Ian Lewis <ian@ianlewis.org>

@ramonpetgrave64 ramonpetgrave64 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll let you merge when you're ready.

Comment thread actions/delegator/setup-generic/dist/index.js Outdated
Comment thread actions/delegator/setup-generic/src/main.ts Outdated
@ianlewis

Copy link
Copy Markdown
Member Author

Looks good, I'll let you merge when you're ready.

Thanks! should be good to go.

@ramonpetgrave64 ramonpetgrave64 merged commit 8e3df77 into slsa-framework:main Jun 24, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] verify-token: Cannot find module '../../store/public-good-instance-root.json'

2 participants