Skip to content

chore: Remove old TODO #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonpetgrave64 merged 2 commits into from
Jun 25, 2025
Merged

chore: Remove old TODO #4152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578887c
chore: Remove old TODO
ianlewis Mar 19, 2025
fecd89d
Merge branch 'main' into 1780-todos
ramonpetgrave64 Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/verify-token/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,8 @@ function run() {
(0, validate_1.validateGitHubFields)(rawTokenObj.github);
// Validate the build Action is not empty.
(0, validate_1.validateFieldNonEmpty)("tool.actions.build_artifacts.path", rawTokenObj.tool.actions.build_artifacts.path);
// No validation needed for the builder inputs,
// NOTE: No validation needed for the builder inputs,
// they may be empty.
// TODO(#1780): test empty inputs.
// Extract certificate information.
const [toolURI, toolRepository, toolRef, toolSha, toolPath] = (0, utils_1.parseCertificate)(bundle);
// Extract the inputs.
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/verify-token/dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions .github/actions/verify-token/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,8 @@ async function run(): Promise<void> {
rawTokenObj.tool.actions.build_artifacts.path,
);

// No validation needed for the builder inputs,
// NOTE: No validation needed for the builder inputs,
// they may be empty.
// TODO(#1780): test empty inputs.

// Extract certificate information.
const [toolURI, toolRepository, toolRef, toolSha, toolPath] =
Expand Down
Loading