refactor: use contains() for associative-container membership checks#16
Draft
smaheshwar-pltr wants to merge 1 commit into
Draft
refactor: use contains() for associative-container membership checks#16smaheshwar-pltr wants to merge 1 commit into
smaheshwar-pltr wants to merge 1 commit into
Conversation
Replace `find(x) != end()` / `find(x) == end()` membership tests with the C++20 `contains()` member, matching the codebase's prevailing idiom. In metadata_columns.cc this also avoids invoking the accessor twice per call. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
find(x) != end()/find(x) == end()membership tests with the C++20contains(x)member at five sites:metadata_columns.cc,util/content_file_util.cc,util/struct_like_set.cc, andcatalog/rest/auth/auth_properties.cc. Inmetadata_columns.ccthis also avoids invoking the accessor (GetMetadataColumnMap()/GetMetadataFieldIdSet()) twice per call.Why
contains()is already the prevailing idiom in this codebase and reads more clearly for a pure membership check. The change is behavior-preserving: at each converted site thefind()iterator was used only for the boolean test. Sites that dereference the iterator for an actual lookup are intentionally left unchanged.