Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/iceberg/catalog/rest/auth/auth_properties.cc
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Result<AuthProperties> AuthProperties::FromProperties(
}

// Resolve token endpoint: if not explicitly set, derive from catalog URI
if (properties.find(kOAuth2ServerUri.key()) == properties.end() ||
if (!properties.contains(kOAuth2ServerUri.key()) ||
properties.at(kOAuth2ServerUri.key()).empty()) {
auto uri_it = properties.find(RestCatalogProperties::kUri.key());
if (uri_it != properties.end() && !uri_it->second.empty()) {
Expand Down
5 changes: 2 additions & 3 deletions src/iceberg/metadata_columns.cc
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,11 @@ const std::set<int32_t>& MetadataColumns::MetadataFieldIds() {
}

bool MetadataColumns::IsMetadataColumn(std::string_view name) {
return name == kPartitionColumnName ||
GetMetadataColumnMap().find(name) != GetMetadataColumnMap().end();
return name == kPartitionColumnName || GetMetadataColumnMap().contains(name);
}

bool MetadataColumns::IsMetadataColumn(int32_t id) {
return GetMetadataFieldIdSet().find(id) != GetMetadataFieldIdSet().end();
return GetMetadataFieldIdSet().contains(id);
}

Result<const SchemaField*> MetadataColumns::MetadataColumn(std::string_view name) {
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/util/content_file_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ template <typename V>
void DropUnselectedColumnStats(std::map<int32_t, V>& map,
const std::unordered_set<int32_t>& columns) {
for (auto it = map.begin(); it != map.end();) {
if (columns.find(it->first) == columns.end()) {
if (!columns.contains(it->first)) {
it = map.erase(it);
} else {
++it;
Expand Down
2 changes: 1 addition & 1 deletion src/iceberg/util/struct_like_set.cc
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ Result<bool> StructLikeSet<kValidate>::Contains(const StructLike& row) const {
if constexpr (kValidate) {
ICEBERG_RETURN_UNEXPECTED(ValidateRowAgainstTypes(row, field_types_));
}
return set_.find(row) != set_.end();
return set_.contains(row);
}

template <bool kValidate>
Expand Down
Loading