refactor: drop redundant Overloaded deduction guide#18
Draft
smaheshwar-pltr wants to merge 1 commit into
Draft
Conversation
C++20 aggregate CTAD deduces Overloaded's template arguments from its aggregate initializer, so the explicit deduction guide is no longer needed. The project requires C++23 with a compiler floor (GCC 14+, Clang 18+, MSVC 2022+) where aggregate CTAD is supported. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the explicit deduction guide for the local
Overloadedstd::visithelper instruct_like_set.cc. TheOverloadedstruct and its fourOverloaded{...}call sites are unchanged.Why
Under C++20 aggregate CTAD (P1816 / P2082),
Overloaded's template arguments are deduced directly from its aggregate initializer, making the hand-written deduction guide redundant. The project requires C++23 with a documented compiler floor (GCC 14+, Clang 18+, MSVC 2022+), all of which support aggregate CTAD for this pattern.