feat: make SnapshotUtil a public installed header#4
Open
smaheshwar-pltr wants to merge 2 commits into
Open
Conversation
Rename snapshot_util_internal.h to snapshot_util.h so that it is included in the installed headers. The iceberg_install_all_headers CMake function skips any header whose filename contains "internal", which prevented downstream consumers using find_package(iceberg) from accessing SnapshotUtil without vendoring a copy. The class is already marked ICEBERG_EXPORT (public ABI), so the "_internal" suffix was inconsistent. SnapshotUtil provides essential snapshot operations (ancestry traversal, time travel, schema lookup) that engines built on iceberg-cpp need. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
smaheshwar-pltr
force-pushed
the
make-snapshot-util-public
branch
from
7ffc6d8 to
4908911
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #8
SnapshotUtilprovides essential snapshot operations (ancestry traversal, time-travel queries, schema lookup) that consumers using iceberg-cpp viafind_package(iceberg)need. The class is markedICEBERG_EXPORT(public ABI), but the header is namedsnapshot_util_internal.h. Theiceberg_install_all_headersCMake function skips filenames containing "internal", so the header is never installed.Consumers using iceberg-cpp as an installed package hit:
PR
snapshot_util_internal.htosnapshot_util.hso it is included in the installed headersiceberg_install_all_headersCMake function skips filenames containing "internal", which prevented downstream consumers usingfind_package(iceberg)from accessingSnapshotUtilwithout vendoring a copyICEBERG_EXPORT(public ABI), so the_internalsuffix was inconsistent with the intended visibilityMotivation
SnapshotUtilprovides essential snapshot operations (ancestry traversal, time travel queries, schema lookup) that any engine built on iceberg-cpp needs. The class was always intended to be public (evidenced by theICEBERG_EXPORTmacro), but the_internalfilename suffix prevented the header from being installed.Changes
src/iceberg/util/snapshot_util_internal.h->src/iceberg/util/snapshot_util.h#includethis headerNo CMake or Meson build file changes needed -- the
.ccfile was already namedsnapshot_util.cc, and the install function works by globbing*.hand filtering out*internal*names.Test plan
snapshot_util_testcontinues to pass (include path updated)cmake --install