Skip to content

Commit 5490873

Browse files
JeffRescjessebot
andauthored
Allow custom database readiness image when using external database (#176)
* allow custom image for database readiness check * bump chart version to 8.3.1 --------- Co-authored-by: Jesse Hitch <jessebot@linux.com>
1 parent 291f830 commit 5490873

4 files changed

Lines changed: 15 additions & 7 deletions

File tree

charts/coturn/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ type: application
44
description: A Helm chart to deploy coturn
55
home: "https://github.com/small-hack/coturn-chart"
66

7-
version: 8.4.0
7+
version: 8.5.0
88

99
# renovate: image=coturn/coturn
1010
appVersion: 4.7.0

charts/coturn/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# coturn
22

3-
![Version: 8.4.0](https://img.shields.io/badge/Version-8.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.7.0](https://img.shields.io/badge/AppVersion-4.7.0-informational?style=flat-square)
3+
![Version: 8.5.0](https://img.shields.io/badge/Version-8.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.7.0](https://img.shields.io/badge/AppVersion-4.7.0-informational?style=flat-square)
44

55
A Helm chart to deploy coturn
66

@@ -54,6 +54,8 @@ A Helm chart to deploy coturn
5454
| externalDatabase.enabled | bool | `false` | enables the use of postgresql instead of the default sqlite to use the bundled subchart, enable this, and postgresql.enable |
5555
| externalDatabase.existingSecret | string | `""` | name of existing Secret to use for postgresql credentials |
5656
| externalDatabase.hostname | string | `""` | required if externalDatabase.enabled: true and postgresql.enabled: false |
57+
| externalDatabase.image.repository | string | `""` | container registry and repo for database readiness docker image |
58+
| externalDatabase.image.tag | string | `""` | container tag for coturn database readiness docker image |
5759
| externalDatabase.password | string | `""` | password for database, ignored if existingSecret is passed in |
5860
| externalDatabase.secretKeys.database | string | `""` | key in existing Secret to use for the database name |
5961
| externalDatabase.secretKeys.hostname | string | `""` | key in existing Secret to use for the db's hostname |
@@ -97,4 +99,4 @@ A Helm chart to deploy coturn
9799
| service.type | string | `"ClusterIP"` | The type of service to deploy for routing Coturn traffic. ClusterIP: Recommended for DaemonSet configurations. This will create a standard Kubernetes service for Coturn within the cluster. No external networking will be configured as the DaemonSet will handle binding to each Node's host networking NodePort: Recommended for Deployment configurations. This will open TURN ports on every node and route traffic on these ports to the Coturn pods. You will need to make sure your cloud provider supports the cluster config setting, apiserver.service-node-port-range, as this range must contain the ports defined above for the service to be created. LoadBalancer: This was what was originally set for this chart in the upstream of this fork, but with no details |
98100

99101
----------------------------------------------
100-
Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0)
102+
Autogenerated from chart metadata using [helm-docs v1.14.2](https://github.com/norwoodj/helm-docs/releases/v1.14.2)

charts/coturn/templates/_helpers.tpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ Helper function to get the coturn secret containing admin coturn credentials
5353

5454
{{- define "db.isReady.image.repository" -}}
5555
{{- if and .Values.externalDatabase.enabled (eq .Values.externalDatabase.type "postgresql") -}}
56-
postgres
56+
{{ .Values.externalDatabase.image.repository | default "postgres" }}
5757
{{- else if and .Values.externalDatabase.enabled (eq .Values.externalDatabase.type "mysql") -}}
58-
mysql
58+
{{ .Values.externalDatabase.image.repository | default "mysql" }}
5959
{{- else if .Values.postgresql.enabled -}}
6060
{{ .Values.postgresql.image.repository }}
6161
{{- else if .Values.mysql.enabled -}}
@@ -65,9 +65,9 @@ mysql
6565

6666
{{- define "db.isReady.image.tag" -}}
6767
{{- if and .Values.externalDatabase.enabled (eq .Values.externalDatabase.type "postgresql") -}}
68-
15-alpine
68+
{{ .Values.externalDatabase.image.tag | default "15-alpine" }}
6969
{{- else if and .Values.externalDatabase.enabled (eq .Values.externalDatabase.type "mysql") -}}
70-
8.0.35
70+
{{ .Values.externalDatabase.image.tag | default "8.0.35" }}
7171
{{- else if .Values.postgresql.enabled -}}
7272
{{ .Values.postgresql.image.tag }}
7373
{{- else if .Values.mysql.enabled -}}

charts/coturn/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ externalDatabase:
7676
database: ""
7777
# -- key in existing Secret to use for the db's hostname
7878
hostname: ""
79+
# Custom image for database readiness check
80+
image:
81+
# -- container registry and repo for database readiness docker image
82+
repository: ""
83+
# -- container tag for coturn database readiness docker image
84+
tag: ""
7985

8086
# PostgreSQL chart configuration
8187
# see: https://github.com/bitnami/charts/tree/main/bitnami/postgresql

0 commit comments

Comments
 (0)