Address review feedback from mskacelik

- Replace .collect(Collectors.toList()) with .toList() (JDK 17+)
- Add missing imports in ResponseImpl and JsonbAnnotationIntrospectorTest
- Use property for jakarta.json.bind-api version instead of hardcoding

Author: phillip-kruger

client/implementation-vertx/src/main/java/io/smallrye/graphql/client/vertx/websocket/graphqltransportws/GraphQLTransportWSSubprotocolHandler.java

@@ -6,7 +6,6 @@
 import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
-import java.util.stream.Collectors;
 import java.util.stream.StreamSupport;
 
 import org.jboss.logging.Logger;
@@ -209,7 +208,7 @@ private void handleData(String operationId, ObjectNode data) {
     private void handleOperationError(String operationId, ArrayNode errors) {
         List<GraphQLError> parsedErrors = StreamSupport.stream(errors.spliterator(), false)
                 .map(ResponseReader::readError)
-                .collect(Collectors.toList());
+                .toList();
         GraphQLClientException exception = new GraphQLClientException("Received an error", parsedErrors);
         UniEmitter<? super String> emitter = uniOperations.remove(operationId);
         if (emitter != null) {

client/implementation/src/main/java/io/smallrye/graphql/client/impl/ResponseImpl.java

@@ -3,8 +3,10 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.node.ArrayNode;
@@ -140,8 +142,8 @@ private Object getScalarValue(JsonNode value) {
      * Helper to collect field names from an ObjectNode into a Set-like structure
      * for error reporting.
      */
-    private static java.util.Set<String> fieldNames(ObjectNode node) {
-        java.util.Set<String> names = new java.util.LinkedHashSet<>();
+    private static Set<String> fieldNames(ObjectNode node) {
+        Set<String> names = new LinkedHashSet<>();
         node.fieldNames().forEachRemaining(names::add);
         return names;
     }

client/implementation/src/main/java/io/smallrye/graphql/client/impl/typesafe/ResultBuilder.java

@@ -5,7 +5,6 @@
 
 import java.util.List;
 import java.util.Map;
-import java.util.stream.Collectors;
 import java.util.stream.StreamSupport;
 
 import com.fasterxml.jackson.core.JsonPointer;
@@ -118,7 +117,7 @@ private void readErrors() {
         throw new GraphQLClientException("errors from service",
                 StreamSupport.stream(unapplied.spliterator(), false)
                         .map(ResponseReader::readError)
-                        .collect(Collectors.toList()));
+                        .toList());
     }
 
     private boolean apply(JsonNode error) {
@@ -185,6 +184,6 @@ private static List<Object> getPath(JsonNode jsonValue) {
         ArrayNode jsonArray = (ArrayNode) value;
         return StreamSupport.stream(jsonArray.spliterator(), false)
                 .map(JsonUtils::toValue)
-                .collect(Collectors.toList());
+                .toList();
     }
 }

common/jackson-jsonb-compat/src/test/java/io/smallrye/graphql/jackson/jsonb/JsonbAnnotationIntrospectorTest.java

@@ -2,18 +2,28 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import java.time.LocalDate;
+import java.util.Locale;
+
+import jakarta.json.bind.annotation.JsonbCreator;
+import jakarta.json.bind.annotation.JsonbDateFormat;
+import jakarta.json.bind.annotation.JsonbNillable;
+import jakarta.json.bind.annotation.JsonbNumberFormat;
 import jakarta.json.bind.annotation.JsonbProperty;
+import jakarta.json.bind.annotation.JsonbSubtype;
 import jakarta.json.bind.annotation.JsonbTransient;
+import jakarta.json.bind.annotation.JsonbTypeInfo;
 
 import org.junit.jupiter.api.Test;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 
 class JsonbAnnotationIntrospectorTest {
 
     private final ObjectMapper mapper = new ObjectMapper()
             .registerModule(new JsonbCompatModule())
-            .registerModule(new com.fasterxml.jackson.datatype.jsr310.JavaTimeModule());
+            .registerModule(new JavaTimeModule());
 
     // -- @JsonbProperty --
 
@@ -54,7 +64,7 @@ static class CreatorBean {
         private final String name;
         private final int age;
 
-        @jakarta.json.bind.annotation.JsonbCreator
+        @JsonbCreator
         public CreatorBean(
                 @JsonbProperty("name") String name,
                 @JsonbProperty("age") int age) {
@@ -80,7 +90,7 @@ void jsonbCreatorUsesAnnotatedConstructor() throws Exception {
 
     // -- @JsonbNillable --
 
-    @jakarta.json.bind.annotation.JsonbNillable
+    @JsonbNillable
     static class NillableBean {
         public String name = null;
         public String other = "value";
@@ -95,8 +105,8 @@ void jsonbNillableIncludesNullFields() throws Exception {
     // -- @JsonbDateFormat --
 
     static class DateFormatBean {
-        @jakarta.json.bind.annotation.JsonbDateFormat("dd.MM.yyyy")
-        public java.time.LocalDate date = java.time.LocalDate.of(2026, 6, 15);
+        @JsonbDateFormat("dd.MM.yyyy")
+        public LocalDate date = LocalDate.of(2026, 6, 15);
     }
 
     @Test
@@ -108,30 +118,30 @@ void jsonbDateFormatSerializesWithPattern() throws Exception {
     @Test
     void jsonbDateFormatDeserializesWithPattern() throws Exception {
         DateFormatBean bean = mapper.readValue("{\"date\":\"15.06.2026\"}", DateFormatBean.class);
-        assertThat(bean.date).isEqualTo(java.time.LocalDate.of(2026, 6, 15));
+        assertThat(bean.date).isEqualTo(LocalDate.of(2026, 6, 15));
     }
 
     // -- @JsonbNumberFormat --
 
     static class NumberFormatBean {
-        @jakarta.json.bind.annotation.JsonbNumberFormat("#,##0.00")
+        @JsonbNumberFormat("#,##0.00")
         public double price = 1234.5;
     }
 
     @Test
     void jsonbNumberFormatSerializesWithPattern() throws Exception {
         ObjectMapper usMapper = new ObjectMapper()
                 .registerModule(new JsonbCompatModule())
-                .setLocale(java.util.Locale.US);
+                .setLocale(Locale.US);
         String json = usMapper.writeValueAsString(new NumberFormatBean());
         assertThat(json).contains("\"1,234.50\"");
     }
 
     // -- @JsonbTypeInfo / @JsonbSubtype --
 
-    @jakarta.json.bind.annotation.JsonbTypeInfo(key = "__typename", value = {
-            @jakarta.json.bind.annotation.JsonbSubtype(alias = "Dog", type = Dog.class),
-            @jakarta.json.bind.annotation.JsonbSubtype(alias = "Cat", type = Cat.class)
+    @JsonbTypeInfo(key = "__typename", value = {
+            @JsonbSubtype(alias = "Dog", type = Dog.class),
+            @JsonbSubtype(alias = "Cat", type = Cat.class)
     })
     interface Animal {
         String getName();

pom.xml

@@ -28,6 +28,7 @@
         <version.smallrye-context-propagation>2.3.0</version.smallrye-context-propagation>
         <version.smallrye-stork>3.0.0.beta2</version.smallrye-stork>
 
+        <version.jakarta.json-b.api>3.0.1</version.jakarta.json-b.api>
         <version.yasson>3.0.4</version.yasson>
         <version.jakarta-json>2.1.3</version.jakarta-json>
         <version.jakarta-validation>3.1.1</version.jakarta-validation>
@@ -243,7 +244,7 @@
             <dependency>
                 <groupId>jakarta.json.bind</groupId>
                 <artifactId>jakarta.json.bind-api</artifactId>
-                <version>3.0.1</version>
+                <version>${version.jakarta.json-b.api}</version>
             </dependency>
             <dependency>
                 <groupId>org.eclipse</groupId>