Skip to content

fix: propagate the last failure in expiring retries #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jponge merged 1 commit into from
Apr 30, 2026
+45 −7
Merged

fix: propagate the last failure in expiring retries #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions implementation/src/main/java/io/smallrye/mutiny/helpers/ExponentialBackoff.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,11 @@ public Publisher<Long> apply(Multi<Throwable> t) {

long checkTime = System.currentTimeMillis() + delay.toMillis();
if (checkTime > expireAt) {
return Uni.createFrom().failure(
failure.addSuppressed(
new IllegalStateException(
"Retries exhausted : " + iteration + " attempts against " + checkTime + "/" + expireAt
+ " expiration",
failure));
+ " expiration"));
return Uni.createFrom().failure(failure);
}
return Uni.createFrom().item((long) iteration).onItem().delayIt()
.onExecutor(executor).by(delay);
Expand Down
46 changes: 42 additions & 4 deletions implementation/src/test/java/io/smallrye/mutiny/groups/UniOnFailureRetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,24 +216,62 @@ public void testRetryWithBackOffReachingMaxAttempt() {

@Test
public void testRetryWithBackOffReachingExpiresIn() {
assertThrows(IllegalStateException.class, () -> {
assertThatThrownBy(() -> {
AtomicInteger count = new AtomicInteger();
Uni.createFrom().<String> emitter(e -> e.fail(new Exception("boom " + count.getAndIncrement())))
.onFailure().retry().withBackOff(Duration.ofMillis(10), Duration.ofSeconds(20)).withJitter(1.0)
.expireIn(90L)
.await().atMost(Duration.ofSeconds(5));
});
}).cause()
.hasMessageContaining("boom")
.satisfies(t -> assertThat(t.getSuppressed())
.hasSize(1)
.allSatisfy(s -> assertThat(s)
.isInstanceOf(IllegalStateException.class)
.hasMessageContaining("Retries exhausted")));
}

@Test
public void testRetryWithBackOffReachingExpiresAt() {
assertThrows(IllegalStateException.class, () -> {
assertThatThrownBy(() -> {
AtomicInteger count = new AtomicInteger();
Uni.createFrom().<String> emitter(e -> e.fail(new Exception("boom " + count.getAndIncrement())))
.onFailure().retry().withBackOff(Duration.ofMillis(10), Duration.ofSeconds(20)).withJitter(1.0)
.expireAt(System.currentTimeMillis() + 90L)
.await().atMost(Duration.ofSeconds(5));
});
}).cause()
.hasMessageContaining("boom")
.satisfies(t -> assertThat(t.getSuppressed())
.hasSize(1)
.allSatisfy(s -> assertThat(s)
.isInstanceOf(IllegalStateException.class)
.hasMessageContaining("Retries exhausted")));
}

@Test
public void testRetryWithBackOffReachingExpiresInPropagatesLastFailure() {
assertThatThrownBy(() -> {
AtomicInteger count = new AtomicInteger();
Uni.createFrom().<String> emitter(e -> e.fail(new Exception("boom " + count.getAndIncrement())))
.onFailure().retry().withBackOff(Duration.ofMillis(10), Duration.ofSeconds(20)).withJitter(1.0)
.expireIn(90L)
.await().atMost(Duration.ofSeconds(5));
}).isNotInstanceOf(IllegalStateException.class)
.cause()
.hasMessageContaining("boom");
}

@Test
public void testRetryWithBackOffReachingExpiresAtPropagatesLastFailure() {
assertThatThrownBy(() -> {
AtomicInteger count = new AtomicInteger();
Uni.createFrom().<String> emitter(e -> e.fail(new Exception("boom " + count.getAndIncrement())))
.onFailure().retry().withBackOff(Duration.ofMillis(10), Duration.ofSeconds(20)).withJitter(1.0)
.expireAt(System.currentTimeMillis() + 90L)
.await().atMost(Duration.ofSeconds(5));
}).isNotInstanceOf(IllegalStateException.class)
.cause()
.hasMessageContaining("boom");
}

@Test
Expand Down