-
Notifications
You must be signed in to change notification settings - Fork 202
Kafka handle position and commit offset on seek operations #3453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
9301648
da1d6f0
b03ce7b
249df9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -154,6 +154,11 @@ public void partitionsRevoked(Collection<TopicPartition> partitions) { | |
| delegate.partitionsRevoked(partitions); | ||
| } | ||
|
|
||
| @Override | ||
| public void partitionsSeeked(Collection<TopicPartition> partitions) { | ||
| delegate.partitionsSeeked(partitions); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After a seek, the ordered groups for the affected partitions are holding a stale state (pending counts, buffered items). This could cause records from the new position to be incorrectly ordered or dropped if the group's I think we should consider whether the ordered groups for sought partitions should be canceled and removed, similar to what |
||
| } | ||
|
|
||
| /** | ||
| * Returns the underlying commit handler. | ||
| */ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a copy on write variant - HashSet is not thread-safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the offset stores, it is only accessed on the channel context