Filter non stork configs and read them as optional values#1204
Merged
aureamunoz merged 2 commits intosmallrye:mainfrom Apr 30, 2026
Merged
Filter non stork configs and read them as optional values#1204aureamunoz merged 2 commits intosmallrye:mainfrom
aureamunoz merged 2 commits intosmallrye:mainfrom
Conversation
cescoffier
previously approved these changes
Apr 22, 2026
Contributor
cescoffier
left a comment
There was a problem hiding this comment.
Just 2 minor comments.
a8ae4b3 to
daa1532
Compare
Contributor
|
The Spring Boot config provider doesn't have the equivalent filtering / optional value handling: for (String propertyName : getPropertyNames(environment)) {
StorkConfigUtils.computeServiceProperty(propertiesByServiceName, propertyName,
environment.getProperty(propertyName));
}Should we add it there too? |
cescoffier
previously approved these changes
Apr 24, 2026
daa1532 to
f190e1e
Compare
Collaborator
Author
Yes, I think so for consistency. I saw it at some point but didn't do. It's done in last commit. |
cescoffier
previously approved these changes
Apr 26, 2026
Contributor
cescoffier
left a comment
There was a problem hiding this comment.
See a few minor comments, but nothing is holding the merge.
Refactor improvements
6653966 to
69ff130
Compare
Collaborator
Author
|
I need your approval again to merge |
cescoffier
approved these changes
Apr 30, 2026
cescoffier
added a commit
that referenced
this pull request
May 4, 2026
Refactor improvements Co-authored-by: Clement Escoffier <clement@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1201