Improve api registration#1254
Closed
aureamunoz wants to merge 1 commit into
Closed
Conversation
cescoffier
requested changes
Jun 9, 2026
aureamunoz
force-pushed
the
improve-api-registration-issue-1253
branch
from
June 17, 2026 12:08
3fdc76f to
2428bd6
Compare
cescoffier
requested changes
Jun 24, 2026
| checkAddressNotNull(options.ipAddress()); | ||
|
|
||
| return registerServiceInstance(options.serviceName(), options.ipAddress(), options.defaultPort()); | ||
| return registerServiceInstance(options.serviceName(), null, options.tags(), Metadata.empty(), options.ipAddress(), |
Contributor
There was a problem hiding this comment.
Why Metadata.empty() and not options.metadata() ?
Collaborator
Author
There was a problem hiding this comment.
RegistrarOptions.metadata() is a Map<String, String>, incompatible with Metadata. Implementations that need it (Consul, Eureka) already override this method and read options.metadata() directly.
aureamunoz
force-pushed
the
improve-api-registration-issue-1253
branch
from
June 26, 2026 10:11
2428bd6 to
6e332bc
Compare
aureamunoz
force-pushed
the
improve-api-registration-issue-1253
branch
from
July 3, 2026 11:33
6e332bc to
11d94b2
Compare
aureamunoz
force-pushed
the
improve-api-registration-issue-1253
branch
from
July 8, 2026 08:22
11d94b2 to
5885202
Compare
Collaborator
Author
|
Closing before branch swap. Will reopen against new main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1253