Pass custom header in signing request#343
Open
karthik-murugan-hpe wants to merge 3 commits into
Open
Conversation
Contributor
|
hi @karthik-murugan-hpe, thanks for creating this PR. However, it's possible for us to assign priority for our customers. |
Author
|
Hi @tashian, there were too many such extensions needed to fit our usecase and we ended up developing our own issuer. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature: Custom headers in signing request
Pain or issue this feature alleviates: Custom authentication of Signing Requests is not possible today, because there's no mechanism to include a token or credential in the request
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where? Added a section to README
In what environments or workflows is this feature supported? Leveraging this feature also requires a gateway in front of the step-ca to authenticate based on the header.
In what environments or workflows is this feature explicitly NOT supported (if any)? As mentioned above, this feature requires an authentication mechanism implemented in front of step-ca
Supporting links/other PRs/issues:
💔Thank you!#