move to action sevrer#302
Draft
doclorenzo wants to merge 2 commits into
Draft
Conversation
NinjaTuna007
suggested changes
Apr 17, 2026
NinjaTuna007
left a comment
NinjaTuna007
left a comment
There was a problem hiding this comment.
Some restructuring required (configurable params through ymls inside a config directory, launchfiles modified to accept config ymls
| parameters=[{ | ||
| 'robot_name': robot_name, | ||
| 'use_sim': use_sim, | ||
| "yaw_p_gain": 0.3, |
There was a problem hiding this comment.
Do you just hardcode these gain values or is there a way to read these values from a config file?
A config directory with yml files storing different configurations, and a modified launchfile allowing you to handle different configs, would be a great idea.
Goes for ALL ACTION SERVERS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move to action server