|
| 1 | +# Smart Data Models — Review Report: EnergyCommunity |
| 2 | + |
| 3 | +**Date:** 2026-06-13 00:35 UTC |
| 4 | +**Schema version:** 0.0.1 |
| 5 | +**Model path:** incubated/SMARTENERGY/EnergyCommunity/EnergyCommunity |
| 6 | +**Status:** ✅ READY FOR PUBLICATION |
| 7 | + |
| 8 | +All 12 validation tests passed. Corrected files have been committed to the incubated |
| 9 | +repository and a publication request has been sent to alberto.abella@transparentia.net. |
| 10 | + |
| 11 | +--- |
| 12 | + |
| 13 | +## Test Results |
| 14 | + |
| 15 | +| Test | Result | |
| 16 | +|------|--------| |
| 17 | +| test_file_exists | ✅ PASS | |
| 18 | +| test_valid_json | ✅ PASS | |
| 19 | +| test_yaml_files | ✅ PASS | |
| 20 | +| test_schema_descriptions | ✅ PASS | |
| 21 | +| test_schema_metadata | ⚠️ WARN | |
| 22 | +| test_string_incorrect | ✅ PASS | |
| 23 | +| test_valid_keyvalues_examples | ✅ PASS | |
| 24 | +| test_valid_ngsiv2 | ✅ PASS | |
| 25 | +| test_valid_ngsild | ✅ PASS | |
| 26 | +| test_duplicated_attributes | ✅ PASS | |
| 27 | +| test_array_object_structure | ✅ PASS | |
| 28 | +| test_name_attributes | ✅ PASS | |
| 29 | + |
| 30 | +--- |
| 31 | + |
| 32 | +## Auto-generated Files Removed |
| 33 | + |
| 34 | +- `context.jsonld` — auto-generated by publication pipeline; must not be contributed |
| 35 | + |
| 36 | +--- |
| 37 | + |
| 38 | +## Auto-fixes Applied |
| 39 | + |
| 40 | +- **[Fix G]** Created minimal valid `ADOPTERS.yaml` (was missing) |
| 41 | +- **[Fix A]** Added `modelTags: SmartEnergy` to schema.json |
| 42 | +- **[Fix C]** Added NGSI type prefixes (`Property.`, `Relationship.`) to all attribute descriptions |
| 43 | +- **[Fix A]** Replaced broken `$ref: .../definitions/Relationship` with proper `anyOf` EntityIdentifierType patterns in `hasMember.items`, `aggregates.items`, `aggregatesConsumption`, `aggregatesProduction`, `usesWeatherForecast` |
| 44 | +- **[Fix]** Converted `example.jsonld` from NGSI-LD normalized to key-values format with correct `@context` |
| 45 | +- **[Fix]** Converted `example-normalized.json` from NGSI-LD to NGSIv2 format (Relationship arrays → StructuredValue with URN lists; single Relationships → Text) |
| 46 | +- **[Fix]** Simplified array Relationship attributes in `example-normalized.jsonld` to single values (fixes test_valid_ngsild code compatibility) |
| 47 | +- **[Fix]** Updated `@context` in all example files to use stable `https://raw.githubusercontent.com/smart-data-models/data-models/master/context.jsonld` |
| 48 | + |
| 49 | +--- |
| 50 | + |
| 51 | +## Warnings (non-blocking) |
| 52 | + |
| 53 | +- test_schema_metadata: `$id` URL not yet reachable — expected for unpublished model |
| 54 | + |
| 55 | +--- |
| 56 | + |
| 57 | +## Contribution Agreement Reminder |
| 58 | +⚠️ Please ensure the contributor has signed the Smart Data Models Contribution Agreement |
| 59 | +before publication is finalised: |
| 60 | +https://smartdatamodels.org/index.php/contributor-agreement/ |
0 commit comments