-
Notifications
You must be signed in to change notification settings - Fork 36
Expand file tree
/
Copy pathcontracts_test.go
More file actions
710 lines (607 loc) · 23.6 KB
/
Copy pathcontracts_test.go
File metadata and controls
710 lines (607 loc) · 23.6 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
package httpapi
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"os"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/config"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/contracts"
internalRuntime "github.com/smart-mcp-proxy/mcpproxy-go/internal/runtime"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/secret"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/storage"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/updatecheck"
"github.com/smart-mcp-proxy/mcpproxy-go/internal/upstream/core"
)
// MockServerController implements ServerController for testing
type MockServerController struct{}
// mockManagementService provides a test implementation of management service methods
type mockManagementService struct{}
func (m *mockManagementService) ListServers(ctx context.Context) ([]*contracts.Server, *contracts.ServerStats, error) {
return []*contracts.Server{
{
ID: "test-server",
Name: "test-server",
Protocol: "stdio",
Command: "echo",
Args: []string{"hello"},
Enabled: true,
Quarantined: false,
Connected: true,
Status: "Ready",
ToolCount: 5,
ReconnectCount: 0,
Authenticated: false,
},
}, &contracts.ServerStats{
TotalServers: 1,
ConnectedServers: 1,
QuarantinedServers: 0,
TotalTools: 5,
}, nil
}
func (m *mockManagementService) EnableServer(ctx context.Context, name string, enabled bool) error {
return nil
}
func (m *mockManagementService) RestartServer(ctx context.Context, name string) error {
return nil
}
func (m *mockManagementService) GetServerTools(ctx context.Context, name string) ([]map[string]interface{}, error) {
return []map[string]interface{}{
{
"name": "echo_tool",
"server_name": name,
"description": "A simple echo tool for testing",
"usage": 10,
},
}, nil
}
func (m *mockManagementService) TriggerOAuthLogin(ctx context.Context, name string) error {
return nil
}
func (m *mockManagementService) TriggerOAuthLoginQuick(ctx context.Context, name string) (*core.OAuthStartResult, error) {
return &core.OAuthStartResult{
AuthURL: "https://example.com/oauth/authorize?client_id=test",
BrowserOpened: true,
CorrelationID: "test-correlation-id",
}, nil
}
func (m *mockManagementService) TriggerOAuthLogout(ctx context.Context, name string) error {
return nil
}
func (m *MockServerController) IsRunning() bool { return true }
func (m *MockServerController) GetListenAddress() string { return ":8080" }
func (m *MockServerController) GetManagementService() interface{} {
return &mockManagementService{}
}
func (m *MockServerController) GetUpstreamStats() map[string]interface{} {
return map[string]interface{}{
"servers": map[string]interface{}{
"test-server": map[string]interface{}{
"connected": true,
"tool_count": 5,
"quarantined": false,
},
},
}
}
func (m *MockServerController) StartServer(_ context.Context) error { return nil }
func (m *MockServerController) StopServer() error { return nil }
func (m *MockServerController) GetStatus() interface{} {
return map[string]interface{}{
"phase": "Ready",
"message": "All systems operational",
}
}
func (m *MockServerController) StatusChannel() <-chan interface{} {
ch := make(chan interface{})
close(ch)
return ch
}
func (m *MockServerController) EventsChannel() <-chan internalRuntime.Event {
ch := make(chan internalRuntime.Event)
close(ch)
return ch
}
func (m *MockServerController) SubscribeEvents() chan internalRuntime.Event {
return make(chan internalRuntime.Event, 16)
}
func (m *MockServerController) UnsubscribeEvents(chan internalRuntime.Event) {}
func (m *MockServerController) GetAllServers() ([]map[string]interface{}, error) {
return []map[string]interface{}{
{
"id": "test-server",
"name": "test-server",
"protocol": "stdio",
"command": "echo",
"args": []interface{}{"hello"},
"enabled": true,
"quarantined": false,
"connected": true,
"status": "Ready",
"tool_count": 5,
"reconnect_count": 0,
"created": "2025-09-19T12:00:00Z",
"updated": "2025-09-19T12:00:00Z",
},
}, nil
}
func (m *MockServerController) EnableServer(_ string, _ bool) error { return nil }
func (m *MockServerController) RestartServer(_ string) error { return nil }
func (m *MockServerController) ForceReconnectAllServers(_ string) error {
return nil
}
func (m *MockServerController) QuarantineServer(_ string, _ bool) error {
return nil
}
func (m *MockServerController) GetQuarantinedServers() ([]map[string]interface{}, error) {
return []map[string]interface{}{}, nil
}
func (m *MockServerController) UnquarantineServer(_ string) error { return nil }
func (m *MockServerController) GetDockerRecoveryStatus() *storage.DockerRecoveryState {
return &storage.DockerRecoveryState{
DockerAvailable: true,
RecoveryMode: false,
FailureCount: 0,
AttemptsSinceUp: 0,
LastError: "",
}
}
func (m *MockServerController) GetRecentSessions(_ int) ([]*contracts.MCPSession, int, error) {
return []*contracts.MCPSession{}, 0, nil
}
func (m *MockServerController) GetSessionByID(_ string) (*contracts.MCPSession, error) {
return nil, nil
}
func (m *MockServerController) GetToolCallsBySession(_ string, _ int, _ int) ([]*contracts.ToolCallRecord, int, error) {
return []*contracts.ToolCallRecord{}, 0, nil
}
func (m *MockServerController) GetServerTools(serverName string) ([]map[string]interface{}, error) {
return []map[string]interface{}{
{
"name": "echo_tool",
"server_name": serverName,
"description": "A simple echo tool for testing",
"usage": 10,
},
}, nil
}
func (m *MockServerController) SearchTools(_ string, _ int) ([]map[string]interface{}, error) {
return []map[string]interface{}{
{
"tool": map[string]interface{}{
"name": "echo_tool",
"server_name": "test-server",
"description": "A simple echo tool for testing",
"usage": 10,
},
"score": 0.95,
},
}, nil
}
func (m *MockServerController) GetServerLogs(_ string, _ int) ([]contracts.LogEntry, error) {
return []contracts.LogEntry{
{
Timestamp: time.Date(2025, 9, 19, 12, 0, 0, 0, time.UTC),
Level: "INFO",
Message: "Server started",
Server: "test-server",
},
{
Timestamp: time.Date(2025, 9, 19, 12, 0, 1, 0, time.UTC),
Level: "INFO",
Message: "Tool registered: echo_tool",
Server: "test-server",
},
}, nil
}
func (m *MockServerController) ReloadConfiguration() error { return nil }
func (m *MockServerController) GetConfigPath() string { return "/test/config.json" }
func (m *MockServerController) GetLogDir() string { return "/test/logs" }
func (m *MockServerController) TriggerOAuthLogin(_ string) error { return nil }
// Secrets management methods
func (m *MockServerController) GetSecretResolver() *secret.Resolver { return nil }
func (m *MockServerController) NotifySecretsChanged(_ context.Context, _, _ string) error {
return nil
}
func (m *MockServerController) GetCurrentConfig() interface{} { return map[string]interface{}{} }
// Tool call history methods
func (m *MockServerController) GetToolCalls(_ int, _ int) ([]*contracts.ToolCallRecord, int, error) {
return []*contracts.ToolCallRecord{}, 0, nil
}
func (m *MockServerController) GetToolCallByID(_ string) (*contracts.ToolCallRecord, error) {
return nil, nil
}
func (m *MockServerController) GetServerToolCalls(_ string, _ int) ([]*contracts.ToolCallRecord, error) {
return []*contracts.ToolCallRecord{}, nil
}
func (m *MockServerController) ReplayToolCall(_ string, _ map[string]interface{}) (*contracts.ToolCallRecord, error) {
return &contracts.ToolCallRecord{
ID: "replayed-call-123",
ServerName: "test-server",
ToolName: "echo_tool",
Arguments: map[string]interface{}{},
}, nil
}
// Activity logging methods
func (m *MockServerController) ListActivities(_ storage.ActivityFilter) ([]*storage.ActivityRecord, int, error) {
return []*storage.ActivityRecord{}, 0, nil
}
func (m *MockServerController) GetActivity(_ string) (*storage.ActivityRecord, error) {
return nil, nil
}
func (m *MockServerController) AggregateToolUsage(_ time.Time) (map[string]storage.ToolUsageStat, error) {
return map[string]storage.ToolUsageStat{}, nil
}
func (m *MockServerController) UsageSnapshot() *internalRuntime.UsageAggregate { return nil }
func (m *MockServerController) StreamActivities(_ storage.ActivityFilter) <-chan *storage.ActivityRecord {
ch := make(chan *storage.ActivityRecord)
close(ch)
return ch
}
// Configuration management methods
func (m *MockServerController) ValidateConfig(_ *config.Config) ([]config.ValidationError, error) {
return []config.ValidationError{}, nil
}
func (m *MockServerController) ApplyConfig(_ *config.Config, _ string) (*internalRuntime.ConfigApplyResult, error) {
return &internalRuntime.ConfigApplyResult{
Success: true,
AppliedImmediately: true,
RequiresRestart: false,
ChangedFields: []string{},
}, nil
}
func (m *MockServerController) GetConfig() (*config.Config, error) {
return &config.Config{
Listen: "127.0.0.1:8080",
TopK: 5,
ToolsLimit: 15,
ToolResponseLimit: 1000,
}, nil
}
// Readiness method
func (m *MockServerController) IsReady() bool { return true }
// Token statistics
func (m *MockServerController) GetTokenSavings() (*contracts.ServerTokenMetrics, error) {
return &contracts.ServerTokenMetrics{}, nil
}
// Tool execution
func (m *MockServerController) CallTool(_ context.Context, _ string, _ map[string]interface{}) (interface{}, error) {
return map[string]interface{}{"result": "success"}, nil
}
// Registry browsing
func (m *MockServerController) ListRegistries() ([]interface{}, error) {
return []interface{}{}, nil
}
func (m *MockServerController) SearchRegistryServers(_, _, _ string, _ int) ([]interface{}, *contracts.RegistryCacheInfo, error) {
return []interface{}{}, nil, nil
}
func (m *MockServerController) RefreshRegistryCache(_ string) (int, error) {
return 0, nil
}
func (m *MockServerController) AddServerFromRegistryRef(_ context.Context, _, _, _ string, _ map[string]string, _ *bool) (*config.ServerConfig, *contracts.RegistryAddError, error) {
return nil, nil, nil
}
func (m *MockServerController) AddRegistrySourceRef(_, _, _, _ string) (*config.RegistryEntry, *contracts.RegistryAddError, error) {
return nil, nil, nil
}
func (m *MockServerController) RemoveRegistrySourceRef(_ string) (*config.RegistryEntry, *contracts.RegistryAddError, error) {
return nil, nil, nil
}
// Version and updates
func (m *MockServerController) GetVersionInfo() *updatecheck.VersionInfo {
return nil
}
func (m *MockServerController) RefreshVersionInfo() *updatecheck.VersionInfo {
return nil
}
// Tool discovery
func (m *MockServerController) DiscoverServerTools(_ context.Context, _ string) error {
return nil
}
// Server management
func (m *MockServerController) AddServer(_ context.Context, _ *config.ServerConfig) error {
return nil
}
func (m *MockServerController) RemoveServer(_ context.Context, _ string) error {
return nil
}
func (m *MockServerController) UpdateServer(_ context.Context, _ string, _ *config.ServerConfig) error {
return nil
}
// Tool-level quarantine (Spec 032)
func (m *MockServerController) ListToolApprovals(_ string) ([]*storage.ToolApprovalRecord, error) {
return nil, nil
}
func (m *MockServerController) ApproveTools(_ string, _ []string, _ string) error { return nil }
func (m *MockServerController) ApproveAllTools(_ string, _ string) (int, error) { return 0, nil }
func (m *MockServerController) GetToolApproval(_, _ string) (*storage.ToolApprovalRecord, error) {
return nil, nil
}
func (m *MockServerController) GetToolApprovalStatus(_, _ string) (string, error) { return "", nil }
func (m *MockServerController) GetOnboardingState() (*storage.OnboardingState, error) {
return &storage.OnboardingState{}, nil
}
func (m *MockServerController) SaveOnboardingState(_ *storage.OnboardingState) error { return nil }
func (m *MockServerController) GetActivationFirstMCPClient() (bool, []string) { return false, nil }
// Test contract compliance for API responses
func TestAPIContractCompliance(t *testing.T) {
logger := zaptest.NewLogger(t).Sugar()
controller := &MockServerController{}
server := NewServer(controller, logger, nil)
tests := []struct {
name string
method string
path string
expectedType string
goldenFile string
}{
{
name: "GET /api/v1/servers",
method: "GET",
path: "/api/v1/servers",
expectedType: "GetServersResponse",
goldenFile: "get_servers.json",
},
{
name: "GET /api/v1/servers/test-server/tools",
method: "GET",
path: "/api/v1/servers/test-server/tools",
expectedType: "GetServerToolsResponse",
goldenFile: "get_server_tools.json",
},
{
name: "GET /api/v1/index/search",
method: "GET",
path: "/api/v1/index/search?q=echo",
expectedType: "SearchToolsResponse",
goldenFile: "search_tools.json",
},
{
name: "GET /api/v1/servers/test-server/logs",
method: "GET",
path: "/api/v1/servers/test-server/logs?tail=10",
expectedType: "GetServerLogsResponse",
goldenFile: "get_server_logs.json",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Create request
req := httptest.NewRequest(tt.method, tt.path, http.NoBody)
w := httptest.NewRecorder()
// Execute request
server.ServeHTTP(w, req)
// Check status code
assert.Equal(t, http.StatusOK, w.Code, "Expected 200 OK")
// Parse response
var response contracts.APIResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
require.NoError(t, err, "Response should be valid JSON")
// Verify it's a success response
assert.True(t, response.Success, "Response should indicate success")
assert.Empty(t, response.Error, "Success response should not have error")
assert.NotNil(t, response.Data, "Success response should have data")
// Validate specific response type structure
validateResponseType(t, response.Data, tt.expectedType)
// Update golden file if needed (useful for initial creation)
if updateGolden() {
updateGoldenFile(t, tt.goldenFile, w.Body.Bytes())
} else {
// Compare with golden file
compareWithGoldenFile(t, tt.goldenFile, w.Body.Bytes())
}
})
}
}
func validateResponseType(t *testing.T, data interface{}, expectedType string) {
dataMap, ok := data.(map[string]interface{})
require.True(t, ok, "Response data should be a map")
switch expectedType {
case "GetServersResponse":
assert.Contains(t, dataMap, "servers", "GetServersResponse should have servers field")
assert.Contains(t, dataMap, "stats", "GetServersResponse should have stats field")
servers, ok := dataMap["servers"].([]interface{})
assert.True(t, ok, "servers should be an array")
if len(servers) > 0 {
server := servers[0].(map[string]interface{})
assert.Contains(t, server, "id", "Server should have id field")
assert.Contains(t, server, "name", "Server should have name field")
assert.Contains(t, server, "enabled", "Server should have enabled field")
}
case "GetServerToolsResponse":
assert.Contains(t, dataMap, "server_name", "GetServerToolsResponse should have server_name field")
assert.Contains(t, dataMap, "tools", "GetServerToolsResponse should have tools field")
assert.Contains(t, dataMap, "count", "GetServerToolsResponse should have count field")
case "SearchToolsResponse":
assert.Contains(t, dataMap, "query", "SearchToolsResponse should have query field")
assert.Contains(t, dataMap, "results", "SearchToolsResponse should have results field")
assert.Contains(t, dataMap, "total", "SearchToolsResponse should have total field")
assert.Contains(t, dataMap, "took", "SearchToolsResponse should have took field")
case "GetServerLogsResponse":
assert.Contains(t, dataMap, "server_name", "GetServerLogsResponse should have server_name field")
assert.Contains(t, dataMap, "logs", "GetServerLogsResponse should have logs field")
assert.Contains(t, dataMap, "count", "GetServerLogsResponse should have count field")
}
}
func updateGolden() bool {
return os.Getenv("UPDATE_GOLDEN") == "true"
}
func updateGoldenFile(t *testing.T, filename string, data []byte) {
goldenDir := "testdata/golden"
err := os.MkdirAll(goldenDir, 0755)
require.NoError(t, err)
goldenPath := filepath.Join(goldenDir, filename)
// Format JSON for readability
var jsonData interface{}
err = json.Unmarshal(data, &jsonData)
require.NoError(t, err)
formattedData, err := json.MarshalIndent(jsonData, "", " ")
require.NoError(t, err)
err = os.WriteFile(goldenPath, formattedData, 0644)
require.NoError(t, err)
t.Logf("Updated golden file: %s", goldenPath)
}
func compareWithGoldenFile(t *testing.T, filename string, actual []byte) {
goldenPath := filepath.Join("testdata", "golden", filename)
if _, err := os.Stat(goldenPath); os.IsNotExist(err) {
t.Logf("Golden file %s does not exist. Run with UPDATE_GOLDEN=true to create it.", goldenPath)
return
}
expected, err := os.ReadFile(goldenPath)
require.NoError(t, err)
// Parse both to compare structure, ignoring formatting differences
var expectedJSON, actualJSON interface{}
err = json.Unmarshal(expected, &expectedJSON)
require.NoError(t, err)
err = json.Unmarshal(actual, &actualJSON)
require.NoError(t, err)
assert.Equal(t, expectedJSON, actualJSON, "Response should match golden file %s", filename)
}
// Test that all endpoints return properly typed responses
func TestEndpointResponseTypes(t *testing.T) {
logger := zaptest.NewLogger(t).Sugar()
controller := &MockServerController{}
server := NewServer(controller, logger, nil)
// Test server action endpoints (ServerActionResponse)
actionTests := []struct {
method string
path string
action string
}{
{"POST", "/api/v1/servers/test-server/enable", "enable"},
{"POST", "/api/v1/servers/test-server/disable", "disable"},
{"POST", "/api/v1/servers/test-server/restart", "restart"},
{"POST", "/api/v1/servers/test-server/logout", "logout"},
}
for _, tt := range actionTests {
t.Run(tt.path, func(t *testing.T) {
req := httptest.NewRequest(tt.method, tt.path, http.NoBody)
w := httptest.NewRecorder()
server.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
var response contracts.APIResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
require.NoError(t, err)
assert.True(t, response.Success)
// Validate ServerActionResponse structure
data, ok := response.Data.(map[string]interface{})
require.True(t, ok)
assert.Contains(t, data, "server")
assert.Contains(t, data, "action")
assert.Contains(t, data, "success")
assert.Equal(t, tt.action, data["action"])
})
}
// Test login endpoint (Spec 020: returns OAuthStartResponse instead of ServerActionResponse)
t.Run("/api/v1/servers/test-server/login", func(t *testing.T) {
req := httptest.NewRequest("POST", "/api/v1/servers/test-server/login", http.NoBody)
w := httptest.NewRecorder()
server.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code)
var response contracts.APIResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
require.NoError(t, err)
assert.True(t, response.Success)
// Validate OAuthStartResponse structure (Spec 020)
data, ok := response.Data.(map[string]interface{})
require.True(t, ok)
assert.Contains(t, data, "server_name")
assert.Contains(t, data, "success")
assert.Contains(t, data, "correlation_id")
assert.Contains(t, data, "browser_opened")
assert.Contains(t, data, "message")
assert.Equal(t, "test-server", data["server_name"])
assert.Equal(t, true, data["success"])
assert.Equal(t, true, data["browser_opened"])
})
}
// Test /api/v1/info endpoint returns version information
func TestInfoEndpointReturnsVersion(t *testing.T) {
logger := zaptest.NewLogger(t).Sugar()
controller := &MockServerController{}
server := NewServer(controller, logger, nil)
req := httptest.NewRequest("GET", "/api/v1/info", http.NoBody)
w := httptest.NewRecorder()
server.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code, "Expected 200 OK")
var response contracts.APIResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
require.NoError(t, err, "Response should be valid JSON")
// Verify it's a success response
assert.True(t, response.Success, "Response should indicate success")
// Validate InfoResponse structure
data, ok := response.Data.(map[string]interface{})
require.True(t, ok, "Response data should be a map")
// Check required fields
assert.Contains(t, data, "version", "InfoResponse should have version field")
assert.Contains(t, data, "listen_addr", "InfoResponse should have listen_addr field")
assert.Contains(t, data, "web_ui_url", "InfoResponse should have web_ui_url field")
assert.Contains(t, data, "endpoints", "InfoResponse should have endpoints field")
// Version should be a non-empty string
version, ok := data["version"].(string)
assert.True(t, ok, "version should be a string")
assert.NotEmpty(t, version, "version should not be empty")
// Verify endpoints structure
endpoints, ok := data["endpoints"].(map[string]interface{})
assert.True(t, ok, "endpoints should be a map")
assert.Contains(t, endpoints, "http", "endpoints should have http field")
assert.Contains(t, endpoints, "socket", "endpoints should have socket field")
}
// Test /api/v1/info endpoint includes update info when available
func TestInfoEndpointIncludesUpdateInfo(t *testing.T) {
logger := zaptest.NewLogger(t).Sugar()
// Create a mock controller with update info
controller := &MockControllerWithUpdateInfo{}
server := NewServer(controller, logger, nil)
req := httptest.NewRequest("GET", "/api/v1/info", http.NoBody)
w := httptest.NewRecorder()
server.ServeHTTP(w, req)
assert.Equal(t, http.StatusOK, w.Code, "Expected 200 OK")
var response contracts.APIResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
require.NoError(t, err, "Response should be valid JSON")
assert.True(t, response.Success, "Response should indicate success")
data, ok := response.Data.(map[string]interface{})
require.True(t, ok, "Response data should be a map")
// Check that update field is present when version info is available
assert.Contains(t, data, "update", "InfoResponse should have update field when version info is available")
updateInfo, ok := data["update"].(map[string]interface{})
assert.True(t, ok, "update should be a map")
// Verify update info structure
assert.Contains(t, updateInfo, "available", "update info should have available field")
assert.Contains(t, updateInfo, "latest_version", "update info should have latest_version field")
}
// MockControllerWithUpdateInfo extends MockServerController with update info
type MockControllerWithUpdateInfo struct {
MockServerController
}
func (m *MockControllerWithUpdateInfo) GetVersionInfo() *updatecheck.VersionInfo {
return &updatecheck.VersionInfo{
CurrentVersion: "v1.0.0",
LatestVersion: "v1.1.0",
UpdateAvailable: true,
ReleaseURL: "https://github.com/user/mcpproxy-go/releases/tag/v1.1.0",
}
}
func (m *MockControllerWithUpdateInfo) RefreshVersionInfo() *updatecheck.VersionInfo {
return m.GetVersionInfo()
}
// Benchmark API response marshaling
func BenchmarkAPIResponseMarshaling(b *testing.B) {
logger := zaptest.NewLogger(b).Sugar()
controller := &MockServerController{}
server := NewServer(controller, logger, nil)
req := httptest.NewRequest("GET", "/api/v1/servers", http.NoBody)
b.ResetTimer()
for i := 0; i < b.N; i++ {
w := httptest.NewRecorder()
server.ServeHTTP(w, req)
}
}