Commit 31ee931
fix(build): use correct module path in ldflags for version injection (#287)
The buildVersion variable in internal/httpapi was not being set during
release builds because ldflags used an incorrect module path:
- Incorrect: -X mcpproxy-go/internal/httpapi.buildVersion=...
- Correct: -X github.com/smart-mcp-proxy/mcpproxy-go/internal/httpapi.buildVersion=...
This caused 'mcpproxy doctor' and the web UI to always show "development"
instead of the actual version. The CLI --version flag worked correctly
because main.version uses the special 'main' package shorthand.
Fixed in:
- .github/workflows/release.yml
- Makefile
- scripts/build.sh
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>1 parent 47cc680 commit 31ee931
3 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
369 | 369 | | |
370 | 370 | | |
371 | 371 | | |
372 | | - | |
| 372 | + | |
373 | 373 | | |
374 | 374 | | |
375 | 375 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
0 commit comments